unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master e91848344e: Pass through caret position from native GTK
Date: Mon, 10 Jan 2022 08:27:15 +0800	[thread overview]
Message-ID: <875yqssae4.fsf@yahoo.com> (raw)
In-Reply-To: <83sftwalcn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jan 2022 19:07:52 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> Is it really correct to use SCHARS in the first argument to
> Fput_text_property?  It should be SCHARS(..)-1, I think, as the
> characters in a string are indexed zero-based.
>
> (There are several places in this commit where I spotted the same
> code.)
>
> Thanks.

Good catch, thanks.



      reply	other threads:[~2022-01-10  0:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 17:07 master e91848344e: Pass through caret position from native GTK Eli Zaretskii
2022-01-10  0:27 ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yqssae4.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).