unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master e91848344e: Pass through caret position from native GTK
Date: Sun, 09 Jan 2022 19:07:52 +0200	[thread overview]
Message-ID: <83sftwalcn.fsf@gnu.org> (raw)

> --- a/src/gtkutil.c
> +++ b/src/gtkutil.c
> @@ -6089,6 +6089,13 @@ xg_im_context_preedit_changed (GtkIMContext *imc, gpointer user_data)
>    EVENT_INIT (inev);
>    inev.kind = PREEDIT_TEXT_EVENT;
>    inev.arg = build_string_from_utf8 (str);
> +
> +  Fput_text_property (make_fixnum (min (SCHARS (inev.arg),  <<<<<<<<<<<<
> +					max (0, cursor))),
> +		      make_fixnum (min (SCHARS (inev.arg),
> +					max (0, cursor) + 1)),
> +		      Qcursor, Qt, inev.arg);

Is it really correct to use SCHARS in the first argument to
Fput_text_property?  It should be SCHARS(..)-1, I think, as the
characters in a string are indexed zero-based.

(There are several places in this commit where I spotted the same
code.)

Thanks.



             reply	other threads:[~2022-01-09 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-09 17:07 Eli Zaretskii [this message]
2022-01-10  0:27 ` master e91848344e: Pass through caret position from native GTK Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sftwalcn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).