* treesit-query-validate
@ 2022-12-17 18:43 Perry Smith
2022-12-17 19:25 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
0 siblings, 1 reply; 7+ messages in thread
From: Perry Smith @ 2022-12-17 18:43 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
I must not know how this function is intended to be used.
What I use to do is go to *scratch*, type in my query and hit C-j and that use to work. But now it puts *scratch* into view-mode and errors off — this is after the message "QUERY is valid” comes out.
This change was at commit 4bccb7b211e465310a34493dea8a66ce395956fc.
I’m perfectly happy changing my mean and ugly ways :-) but how is this function suppose to be used?
It might be that the (view-mode) is nested too far out. ?
(This is on the emacs-29 branch)
Perry
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 18:43 treesit-query-validate Perry Smith
@ 2022-12-17 19:25 ` Theodor Thornhill via Emacs development discussions.
2022-12-17 20:26 ` treesit-query-validate Perry Smith
0 siblings, 1 reply; 7+ messages in thread
From: Theodor Thornhill via Emacs development discussions. @ 2022-12-17 19:25 UTC (permalink / raw)
To: Perry Smith, emacs-devel; +Cc: casouri
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
Hi, Perry!
Perry Smith <pedz@easesoftware.com> writes:
> I must not know how this function is intended to be used.
>
> What I use to do is go to *scratch*, type in my query and hit C-j and
> that use to work. But now it puts *scratch* into view-mode and errors
> off — this is after the message "QUERY is valid” comes out.
>
> This change was at commit 4bccb7b211e465310a34493dea8a66ce395956fc.
>
> I’m perfectly happy changing my mean and ugly ways :-) but how is this
> function suppose to be used?
I usually just do it in the minibuffer, but yes this is a bug.
>
> It might be that the (view-mode) is nested too far out. ?
Yep, you are completely correct. Can you test this patch, Perry?
If reported back positive, can you apply, Yuan?
Theo
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-view-mode-to-the-treesit-query-validate-buffer.patch --]
[-- Type: text/x-diff, Size: 832 bytes --]
From 2def0fca50e8a174bcdacf81ca93a2bd4eb42a23 Mon Sep 17 00:00:00 2001
From: Theodor Thornhill <theo@thornhill.no>
Date: Sat, 17 Dec 2022 20:23:02 +0100
Subject: [PATCH] Add view-mode to the treesit-query-validate buffer
* lisp/treesit.el (treesit-query-validate): Move the (view-mode) into
the correct scope.
---
lisp/treesit.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/treesit.el b/lisp/treesit.el
index 068c443dc2..16e1a16dbf 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -2037,8 +2037,8 @@ treesit-query-validate
(goto-char (point-min))
(insert (format "%s: %d\n" message start))
(forward-char start)))
- (pop-to-buffer buf)))))
- (view-mode))
+ (pop-to-buffer buf)
+ (view-mode))))))
;;; Explorer
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 19:25 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
@ 2022-12-17 20:26 ` Perry Smith
2022-12-17 20:34 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
0 siblings, 1 reply; 7+ messages in thread
From: Perry Smith @ 2022-12-17 20:26 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: emacs-devel, casouri
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>
>
> Hi, Perry!
>
> Perry Smith <pedz@easesoftware.com> writes:
>
>> I must not know how this function is intended to be used.
>>
>> What I use to do is go to *scratch*, type in my query and hit C-j and
>> that use to work. But now it puts *scratch* into view-mode and errors
>> off — this is after the message "QUERY is valid” comes out.
>>
>> This change was at commit 4bccb7b211e465310a34493dea8a66ce395956fc.
>>
>> I’m perfectly happy changing my mean and ugly ways :-) but how is this
>> function suppose to be used?
>
> I usually just do it in the minibuffer, but yes this is a bug.
>
>>
>> It might be that the (view-mode) is nested too far out. ?
>
> Yep, you are completely correct. Can you test this patch, Perry?
>
> If reported back positive, can you apply, Yuan?
I can test it but I have no permissions for the official repository.
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 20:26 ` treesit-query-validate Perry Smith
@ 2022-12-17 20:34 ` Theodor Thornhill via Emacs development discussions.
2022-12-17 20:56 ` treesit-query-validate Perry Smith
0 siblings, 1 reply; 7+ messages in thread
From: Theodor Thornhill via Emacs development discussions. @ 2022-12-17 20:34 UTC (permalink / raw)
To: Perry Smith; +Cc: emacs-devel, casouri
On 17 December 2022 21:26:17 CET, Perry Smith <pedz@easesoftware.com> wrote:
>
>
>> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>
>>
>> Hi, Perry!
>>
>> Perry Smith <pedz@easesoftware.com> writes:
>>
>>> I must not know how this function is intended to be used.
>>>
>>> What I use to do is go to *scratch*, type in my query and hit C-j and
>>> that use to work. But now it puts *scratch* into view-mode and errors
>>> off — this is after the message "QUERY is valid” comes out.
>>>
>>> This change was at commit 4bccb7b211e465310a34493dea8a66ce395956fc.
>>>
>>> I’m perfectly happy changing my mean and ugly ways :-) but how is this
>>> function suppose to be used?
>>
>> I usually just do it in the minibuffer, but yes this is a bug.
>>
>>>
>>> It might be that the (view-mode) is nested too far out. ?
>>
>> Yep, you are completely correct. Can you test this patch, Perry?
>>
>> If reported back positive, can you apply, Yuan?
>
>I can test it but I have no permissions for the official repository.
>
>
>
I just want a verification from you, then Yuan can install when he has time :)
Theo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 20:34 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
@ 2022-12-17 20:56 ` Perry Smith
2022-12-17 21:06 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
0 siblings, 1 reply; 7+ messages in thread
From: Perry Smith @ 2022-12-17 20:56 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: emacs-devel, casouri
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
> On Dec 17, 2022, at 14:34, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>
> On 17 December 2022 21:26:17 CET, Perry Smith <pedz@easesoftware.com> wrote:
>>
>>
>>> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>>
>>
>
> I just want a verification from you, then Yuan can install when he has time :)
It is working for me.
Thanks!
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 20:56 ` treesit-query-validate Perry Smith
@ 2022-12-17 21:06 ` Theodor Thornhill via Emacs development discussions.
2022-12-17 23:34 ` treesit-query-validate Yuan Fu
0 siblings, 1 reply; 7+ messages in thread
From: Theodor Thornhill via Emacs development discussions. @ 2022-12-17 21:06 UTC (permalink / raw)
To: Perry Smith; +Cc: emacs-devel, casouri
Perry Smith <pedz@easesoftware.com> writes:
>> On Dec 17, 2022, at 14:34, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>
>> On 17 December 2022 21:26:17 CET, Perry Smith <pedz@easesoftware.com> wrote:
>>>
>>>
>>>> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>>>
>>>
>>
>> I just want a verification from you, then Yuan can install when he has time :)
>
> It is working for me.
>
> Thanks!
Great! No problem.
Yuan, will you install this for me?
Theo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: treesit-query-validate
2022-12-17 21:06 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
@ 2022-12-17 23:34 ` Yuan Fu
0 siblings, 0 replies; 7+ messages in thread
From: Yuan Fu @ 2022-12-17 23:34 UTC (permalink / raw)
To: Theodor Thornhill; +Cc: Perry Smith, emacs-devel
> On Dec 17, 2022, at 1:06 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>
> Perry Smith <pedz@easesoftware.com> writes:
>
>>> On Dec 17, 2022, at 14:34, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>>
>>> On 17 December 2022 21:26:17 CET, Perry Smith <pedz@easesoftware.com> wrote:
>>>>
>>>>
>>>>> On Dec 17, 2022, at 13:25, Theodor Thornhill via Emacs development discussions. <emacs-devel@gnu.org> wrote:
>>>>>
>>>>
>>>
>>> I just want a verification from you, then Yuan can install when he has time :)
>>
>> It is working for me.
>>
>> Thanks!
>
> Great! No problem.
>
> Yuan, will you install this for me?
Absolutely, I applied and pushed it.
Yuan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-17 23:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-17 18:43 treesit-query-validate Perry Smith
2022-12-17 19:25 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 20:26 ` treesit-query-validate Perry Smith
2022-12-17 20:34 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 20:56 ` treesit-query-validate Perry Smith
2022-12-17 21:06 ` treesit-query-validate Theodor Thornhill via Emacs development discussions.
2022-12-17 23:34 ` treesit-query-validate Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).