boostrap failed because of flyspell-mode-map

boostrap failed because of flyspell-mode-map

[David PONCE]

Hi,

In GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.4.14)
 of 2005-06-07 on localhost
Distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure '--with-gtk'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

After today's update of CVS Emacs, bootstrap failed with this error
when dumping Emacs:

[...]
Loading emacs-lisp/byte-run...
Loading emacs-lisp/backquote...
Loading subr...
Loading version.el (source)...
Loading widget...
Loading custom...
Loading emacs-lisp/map-ynp...
Loading env...
Loading cus-start...
Loading international/mule...
Loading international/mule-conf.el (source)...
Loading format...
Loading bindings...
Loading files...
Loading cus-face...
Loading faces...
Lists of integers (garbage collection statistics) are normal output
while building Emacs; they do not indicate a problem.
((15247 . 4070) (4364 . 4) (549 . 0) 104139 45313 (13 . 1)
 (17 . 0) (4954 . 527))
Loading loaddefs.el (source)...
Symbol's value as variable is void: flyspell-mode-map
make[1]: *** [bootstrap-emacs] Error 255
make[1]: Leaving directory `emacs/src'
make: *** [bootstrap-build] Error 2

It seems that autoload cookies are missing in flyspell.el for
flyspell-mode-map and other variables it refers to.

The following patch fixed the problem for me.

Hope it helps.
Sincerely,
David

2005-06-07  David Ponce  <david@dponce.com>

	* flyspell.el (flyspell-emacs)
	(flyspell-use-meta-tab, flyspell-auto-correct-binding)
	(flyspell-mode-map): Add autoload cookies.

Index: flyspell.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/textmodes/flyspell.el,v
retrieving revision 1.65
diff -c -r1.65 flyspell.el
*** flyspell.el	6 Jun 2005 21:06:19 -0000	1.65
--- flyspell.el	7 Jun 2005 09:10:21 -0000
***************
*** 58,63 ****
--- 58,64 ----
  ;*---------------------------------------------------------------------*/
  ;*    Which emacs are we currently running                             */
  ;*---------------------------------------------------------------------*/
+ ;;;###autoload
  (defvar flyspell-emacs
    (cond
     ((string-match "XEmacs" emacs-version)
***************
*** 66,71 ****
--- 67,73 ----
      'emacs))
    "The type of Emacs we are currently running.")
  
+ ;;;###autoload
  (defvar flyspell-use-local-map
    (or (eq flyspell-emacs 'xemacs)
        (not (string< emacs-version "20"))))
***************
*** 262,272 ****
--- 264,276 ----
    :group 'flyspell
    :type '(choice string (const nil)))
  
+ ;;;###autoload
  (defcustom flyspell-use-meta-tab t
    "*Non-nil means that flyspell uses META-TAB to correct word."
    :group 'flyspell
    :type 'boolean)
  
+ ;;;###autoload
  (defcustom flyspell-auto-correct-binding
    [(control ?\;)]
    "The key binding for flyspell auto correction."
***************
*** 421,426 ****
--- 425,431 ----
      (define-key map [(control \.)] 'flyspell-auto-correct-word)
      map))
  
+ ;;;###autoload
  (defvar flyspell-mode-map
    (let ((map (make-sparse-keymap)))
      ;; mouse, keyboard bindings and misc definition

Re: boostrap failed because of flyspell-mode-map

[Albert Veli]

> The following patch fixed the problem for me.
> 
> Hope it helps.
> Sincerely,
> David
> 

Yes, it works (on Ubuntu) after applying the patch and doing:

$ cd lisp
$ make autoloads EMACS=../src/emacs-22.0.50
$ cd ..
$ make bootstrap

(I'm lucky to have a fast computer :-)

/Albert

boostrap failed because of flyspell-mode-map

[Nick Roberts]

 > After today's update of CVS Emacs, bootstrap failed with this error
 > when dumping Emacs:
 ...

 > It seems that autoload cookies are missing in flyspell.el for
 > flyspell-mode-map and other variables it refers to.
 > 
 > The following patch fixed the problem for me.
 > 
 > Hope it helps.
 > Sincerely,
 > David
 ...

I think the right fix is for someone with a clean checkout of the lisp files
to generate and check in a new version of ldefs-boot.el

Nick

Re: boostrap failed because of flyspell-mode-map

[Lute Kamstra]

David PONCE <david.ponce@wanadoo.fr> writes:

[...]

> After today's update of CVS Emacs, bootstrap failed with this error
> when dumping Emacs:

[...]

> while building Emacs; they do not indicate a problem.
> ((15247 . 4070) (4364 . 4) (549 . 0) 104139 45313 (13 . 1)
>  (17 . 0) (4954 . 527))
> Loading loaddefs.el (source)...
> Symbol's value as variable is void: flyspell-mode-map
> make[1]: *** [bootstrap-emacs] Error 255
> make[1]: Leaving directory `emacs/src'
> make: *** [bootstrap-build] Error 2
>
> It seems that autoload cookies are missing in flyspell.el for
> flyspell-mode-map and other variables it refers to.
>
> The following patch fixed the problem for me.

Using define-minor-mode to implement flyspell-mode seems a cleaner
solution to me.

Lute.

Re: boostrap failed because of flyspell-mode-map

[Lute Kamstra]

Nick Roberts <nickrob@snap.net.nz> writes:

>  > After today's update of CVS Emacs, bootstrap failed with this error
>  > when dumping Emacs:
>  ...
>
>  > It seems that autoload cookies are missing in flyspell.el for
>  > flyspell-mode-map and other variables it refers to.
>  > 
>  > The following patch fixed the problem for me.
>  > 
>  > Hope it helps.
>  > Sincerely,
>  > David
>  ...
>
> I think the right fix is for someone with a clean checkout of the lisp files
> to generate and check in a new version of ldefs-boot.el

Why do you think that will solve the problem?

If I understand things correctly, bootstrap fails because of this
piece of code in flyspell.el:

;;;###autoload
(add-minor-mode 'flyspell-mode
		'flyspell-mode-line-string
		flyspell-mode-map
		nil
		'flyspell-mode)

It results in this piece of code in the generated loaddefs.el:

(add-minor-mode (quote flyspell-mode) (quote flyspell-mode-line-string) flyspell-mode-map nil (quote flyspell-mode))

Since flyspell-mode-map isn't autoloaded (and thus not defined in
loaddefs.el), this gives an error when loaddefs.el is loaded by
loadup.el.  So even a clean checkout will fail to bootstrap.

Removing the add-minor-mode call from flyspell.el and using
define-minor-mode to implement flyspell-mode does solve the problem
for me.


Lute.

Re: boostrap failed because of flyspell-mode-map

[Nick Roberts]

 > > I think the right fix is for someone with a clean checkout of the lisp
 > > files to generate and check in a new version of ldefs-boot.el
 > 
 > Why do you think that will solve the problem?

It won't. Your analysis is more complete than mine. It just seemed to me
that flyspell-mode-map shouldn't be needed to build Emacs and putting back
autoload cookies that Stefan had just removed wasn't the answer.

Nick


 > If I understand things correctly, bootstrap fails because of this
 > piece of code in flyspell.el:
 > 
 > ;;;###autoload
 > (add-minor-mode 'flyspell-mode
 > 		'flyspell-mode-line-string
 > 		flyspell-mode-map
 > 		nil
 > 		'flyspell-mode)
 > 
 > It results in this piece of code in the generated loaddefs.el:
 > 
 > (add-minor-mode (quote flyspell-mode) (quote flyspell-mode-line-string) flyspell-mode-map nil (quote flyspell-mode))
 > 
 > Since flyspell-mode-map isn't autoloaded (and thus not defined in
 > loaddefs.el), this gives an error when loaddefs.el is loaded by
 > loadup.el.  So even a clean checkout will fail to bootstrap.
 > 
 > Removing the add-minor-mode call from flyspell.el and using
 > define-minor-mode to implement flyspell-mode does solve the problem
 > for me.

Re: boostrap failed because of flyspell-mode-map

[Lute Kamstra]

Lute Kamstra <Lute.Kamstra.lists@xs4all.nl> writes:

> Using define-minor-mode to implement flyspell-mode seems a cleaner
> solution to me.

I just installed this fix.  You may have to delete lisp/loaddefs.el to
make bootstrapping work again.

Lute.

Re: boostrap failed because of flyspell-mode-map

[Stefan Monnier]

>> Using define-minor-mode to implement flyspell-mode seems a cleaner
>> solution to me.

> I just installed this fix.  You may have to delete lisp/loaddefs.el to
> make bootstrapping work again.

Thanks,


        Stefan