Re: master 992908b09a: Make connection-local variables user options

Re: master 992908b09a: Make connection-local variables user options

[Robert Pluim]

>>>>> On Mon,  7 Feb 2022 13:32:50 -0500 (EST), Michael Albinus <Michael.Albinus@gmx.de> said:
    Michael> -(defvar connection-local-profile-alist nil
    Michael> +(defcustom connection-local-profile-alist nil
    Michael>    "Alist mapping connection profiles to variable lists.
    Michael>  Each element in this list has the form (PROFILE VARIABLES).
    Michael>  PROFILE is the name of a connection profile (a symbol).
    Michael>  VARIABLES is a list that declares connection-local variables for
    Michael>  PROFILE.  An element in VARIABLES is an alist whose elements are
    Michael> -of the form (VAR . VALUE).")
    Michael> -
    Michael> -(defvar connection-local-criteria-alist nil
    Michael> +of the form (VAR . VALUE)."
    Michael> +  :type '(repeat (cons (symbol :tag "Profile")
    Michael> +                       (repeat :tag "Variables"
    Michael> +                               (cons (symbol :tag "Variable")
    Michael> +                                     (sexp :tag "Value")))))
    Michael> +  :group 'files
    Michael> +  :group 'tramp
    Michael> +  :version "29.1")

If you 'M-x customize-variable RET connection-local-profile-alist',
then customize will complain that this variable has been set outside
customize, which I think is done in tramp-integration.el. If it needs
a default non-nil value, can you not specify it here?

Robert
-- 

Re: master 992908b09a: Make connection-local variables user options

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

Hi Robert,

> If you 'M-x customize-variable RET connection-local-profile-alist',
> then customize will complain that this variable has been set outside
> customize, which I think is done in tramp-integration.el. If it needs
> a default non-nil value, can you not specify it here?

Good idea, I've changed setting these user options to
`customize-set-variable'. Pushed to master.

> Robert

Best regards, Michael.

Re: master 992908b09a: Make connection-local variables user options

[Robert Pluim]

>>>>> On Tue, 08 Feb 2022 16:26:29 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    Michael> Hi Robert,

    >> If you 'M-x customize-variable RET connection-local-profile-alist',
    >> then customize will complain that this variable has been set outside
    >> customize, which I think is done in tramp-integration.el. If it needs
    >> a default non-nil value, can you not specify it here?

    Michael> Good idea, I've changed setting these user options to
    Michael> `customize-set-variable'. Pushed to master.

Thanks (theyʼre now marked as "set for current session only", but they
donʼt get saved when you customize a different variable, so thatʼs
pretty harmless)

Robert
--