* [PATCH v2] Improve find-sibling-rules option type
@ 2023-09-24 9:22 Paul W. Rankin via Emacs development discussions.
2023-09-24 9:29 ` Stefan Kangas
2023-09-24 9:41 ` Po Lu
0 siblings, 2 replies; 3+ messages in thread
From: Paul W. Rankin via Emacs development discussions. @ 2023-09-24 9:22 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul W. Rankin
* lisp/files.el (find-sibling-rules): use alist with tags for custom
type
---
Using regexp type as suggested by Philip Kaludercic
lisp/files.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/files.el b/lisp/files.el
index 9d76668..eb4ed90 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -7572,7 +7572,8 @@ find-sibling-rules
In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
defined as a sibling."
- :type 'sexp
+ :type '(alist :key-type (regexp :tag "Match")
+ :value-type (string :tag "Expansion"))
:version "29.1")
(defun find-sibling-file (file)
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Improve find-sibling-rules option type
2023-09-24 9:22 [PATCH v2] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
@ 2023-09-24 9:29 ` Stefan Kangas
2023-09-24 9:41 ` Po Lu
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2023-09-24 9:29 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul W. Rankin
Please in the future send patches to bug-gnu-emacs@gnu.org, to decrease
the risk that we lose track of them. Thanks in advance.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Improve find-sibling-rules option type
2023-09-24 9:22 [PATCH v2] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
2023-09-24 9:29 ` Stefan Kangas
@ 2023-09-24 9:41 ` Po Lu
1 sibling, 0 replies; 3+ messages in thread
From: Po Lu @ 2023-09-24 9:41 UTC (permalink / raw)
To: Paul W. Rankin via Emacs development discussions.; +Cc: Paul W. Rankin
"Paul W. Rankin" via "Emacs development discussions."
<emacs-devel@gnu.org> writes:
> * lisp/files.el (find-sibling-rules): use alist with tags for custom
> type
Please terminate each sentence within a ChangeLog entry with a period,
capitalize its first word, and do not indent the continuing lines of
each entry.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-24 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-24 9:22 [PATCH v2] Improve find-sibling-rules option type Paul W. Rankin via Emacs development discussions.
2023-09-24 9:29 ` Stefan Kangas
2023-09-24 9:41 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).