unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org,  mattiase@acm.org
Subject: Re: master ddfba511c19 1/3: Check shortdoc keywords and fix one mistake
Date: Mon, 19 Feb 2024 19:25:12 +0000	[thread overview]
Message-ID: <874je49rzb.fsf@posteo.net> (raw)
In-Reply-To: <867cj0p8et.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Feb 2024 21:21:14 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: Mattias Engdegård <mattiase@acm.org>
>> Date: Mon, 19 Feb 2024 18:59:03 +0000
>> 
>> This causes an error while compiling on my end:
>> 
>> emacs-lisp/shortdoc.el:138:2: Error: Symbol’s function definition is
>> void: shortdoc--check
>
> How come? the function is defined before it is used.

Apparently because it is being used in a macro.

>> This would fix it, but I don't know the details of what is going on:
>
> Very strange fix, to say the least.  We should definitely try
> understanding better what's going on.  FTR, if I touch shortdoc.el and
> rebuild Emacs, I see no errors or warnings.  As expected.

Apparently this works as well; I had tried to byte-compile the file
manually and I got the same error, so I assumed something more
complicated was happening.  So disregard this thread.



      reply	other threads:[~2024-02-19 19:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170836288097.22729.10027592558614089561@vcs2.savannah.gnu.org>
     [not found] ` <20240219171441.76EC3C3421F@vcs2.savannah.gnu.org>
2024-02-19 18:59   ` master ddfba511c19 1/3: Check shortdoc keywords and fix one mistake Philip Kaludercic
2024-02-19 19:21     ` Eli Zaretskii
2024-02-19 19:25       ` Philip Kaludercic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874je49rzb.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).