From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master ddfba511c19 1/3: Check shortdoc keywords and fix one mistake Date: Mon, 19 Feb 2024 19:25:12 +0000 Message-ID: <874je49rzb.fsf@posteo.net> References: <170836288097.22729.10027592558614089561@vcs2.savannah.gnu.org> <20240219171441.76EC3C3421F@vcs2.savannah.gnu.org> <87h6i49t6w.fsf@posteo.net> <867cj0p8et.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24429"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, mattiase@acm.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 19 20:25:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rc9Gq-00066Q-7b for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Feb 2024 20:25:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc9GU-0002Q6-F5; Mon, 19 Feb 2024 14:25:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc9GR-0002Pp-32 for emacs-devel@gnu.org; Mon, 19 Feb 2024 14:25:19 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc9GP-0002Uf-5o for emacs-devel@gnu.org; Mon, 19 Feb 2024 14:25:18 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4D454240029 for ; Mon, 19 Feb 2024 20:25:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708370714; bh=96Oy0+XJtCWK06CsxbF+X7SU9XjEG3LVvjal9c3BqSg=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=ZCjFT7ySxcxEdJjbDTWf/e2Y+YvELJSt4bJQDMyRVAyLbMqFnMiqE9Y5K0Ag0HDVb drAwh64McLbAD/6Oj5YogOhKpUZ46d4ESUNt6BXuRiFhdXBecqhFjkTfomr7xkZgny VE3Lg2qkud8zWbKVOEYbXfz3yr81iTGw0XV1h6xHlHWfgh5/sC35xw+3EPFWQdveut stN3NteOVzFDcDnnPquBh+LXSfy0VzYu0L/4WWgFNGYV8d1IZt2++rx1dIzHBSCtAX yWf6udzBStnKZ9QhWwMeU19pH/fZDXxr0tyqVszQA1ZQOtPv8i752fOvnNsPI89Re7 qqF0DELCTrrIw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tdstw5h6cz6tyk; Mon, 19 Feb 2024 20:25:12 +0100 (CET) In-Reply-To: <867cj0p8et.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Feb 2024 21:21:14 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316371 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Mattias Engdeg=C3=A5rd >> Date: Mon, 19 Feb 2024 18:59:03 +0000 >>=20 >> This causes an error while compiling on my end: >>=20 >> emacs-lisp/shortdoc.el:138:2: Error: Symbol=E2=80=99s function definitio= n is >> void: shortdoc--check > > How come? the function is defined before it is used. Apparently because it is being used in a macro. >> This would fix it, but I don't know the details of what is going on: > > Very strange fix, to say the least. We should definitely try > understanding better what's going on. FTR, if I touch shortdoc.el and > rebuild Emacs, I see no errors or warnings. As expected. Apparently this works as well; I had tried to byte-compile the file manually and I got the same error, so I assumed something more complicated was happening. So disregard this thread.