unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* yasnippet common lisp objects broken by recent emacs changes?
@ 2013-01-26 22:59 Christopher Allan Webber
  2013-01-26 23:36 ` Xue Fuqiao
  2013-01-27  0:29 ` Stefan Monnier
  0 siblings, 2 replies; 4+ messages in thread
From: Christopher Allan Webber @ 2013-01-26 22:59 UTC (permalink / raw)
  To: Emacs Development

Heya all,

I noticed that when I try to run yasnippet (running from git as fetched
by el-get) recently I've been getting this error.

It looks like there is a cl--set-getf function that exists and probably
is the same.  If I do this alias, it works:

  (defalias 'cl-set-getf 'cl--set-getf)

...however, there isn't any cl-set-getf method that's actually called or
called in yasnippet itself... I wonder if this is something related to
the way the cl-struct system works, and somethign missing there?

Running from a build from yesterday,
  GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2) of 2013-01-25 on grumps

Backtrace below!
 - Chris

Debugger entered--Lisp error: (void-function cl-set-getf)
  cl-set-getf(("Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil) :keys "title =>")
  yas--update-template-menu([cl-struct-yas--table "org-mode" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("title" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu ... "Title Block")) :keys nil)) nil nil #0] ...)) ...)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil)) nil nil #0] ...)) nil (keymap)] [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil)) nil nil [cl-struct-yas--table "org-mode" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("title" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" #0 ...)) ...)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" #0 ...)) nil (keymap)]])
  yas--update-template([cl-struct-yas--table "org-mode" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("title" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu ... "Title Block")) :keys nil)) nil nil #0] ...)) ...)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil)) nil nil #0] ...)) nil (keymap)] [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil)) nil nil [cl-struct-yas--table "org-mode" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("title" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" #0 ...)) ...)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" #0 ...)) nil (keymap)]])
  yas--define-snippets-1(("title" "#+TITLE: ${1:title}\n" "Title Block" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil nil) [cl-struct-yas--table "org-mode" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("title" #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu ... "Title Block")) :keys nil)) nil nil #0] ...)) ...)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8 data ("Title Block" [cl-struct-yas--template "title" "#+TITLE: ${1:title}\n" "Title Block" nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil "Title Block" ((menu-item "Title Block" (lambda nil (interactive) (yas--expand-or-visit-from-menu (quote org-mode) "Title Block")) :keys nil)) nil nil #0] ...)) nil (keymap)])
  yas-define-snippets(org-mode (("title" "#+TITLE: ${1:title}\n" "Title Block" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/title" nil nil) ("text" "#+TEXT: ${1:text}\n" "Text" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/text" nil nil) ("startup" "#+STARTUP: ${1:options}\n" "Startup" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/startup" nil nil) ("src" "#+BEGIN_SRC $1$>\n$0$>\n#+END_SRC$>\n" "Source Code Block" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/src" nil nil) ("seq" "#+SEQ_TODO: ${1:STATES} | ${2:FINISHED}\n" "SEQ TODO" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/seq" nil nil) ("sb" "#+source: ${1:name}\n#+begin_src ${2:language}\n  $3\n#+end_src\n" "#+srcname:..#+begin_src...#+end_src" nil nil ((yas/indent-line (quote fixed)) (yas/wrap-around-region (quote nil))) "/home/cwebber/elisp/yasnippet-snippets/org-mode/sb" nil nil) ("prop" " :PROPERTIES:\n :VISIBILITY:folded:\n :END:\n" "Properties Folded" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/prop" nil nil) ("options" "#+OPTIONS: ${0}\n\n" "OPTIONS" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/options" nil nil) ("latex" "#+BEGIN_LATEX\n${0}\n#+END_LATEX\n" "LATEX" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/latex" nil nil) ("lang" "#+LANGUAGE: ${1:en}\n" "LANGUAGE" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/lang" nil nil) ("keywords" "#+KEYWORDS: ${0}\n" "KEYWORDS" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/keywords" nil nil) ("inc" "#+INCLUDE: \"${1:file}\" ${2:src-example-quote} ${3:mode}\n\n" "Author" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/inc" nil nil) ("html" "#+BEGIN_HTML\n${0}\n#+END_HTML\n" "HTML" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/html" nil nil) ("figure" "#+attr_latex: width=$1\\textwidth\n`(org-insert-link '(4))`\n$0\n" "figure" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/figure" nil nil) ("email" "#+EMAIL: ${1:`user-mail-address`}\n" "Email" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/email" nil nil) ("docbook" "#+BEGIN_DOCBOOK\n${0}\n#+END_DOCBOOK\n" "DOCBOOK" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/docbook" nil nil) ("dita" "#+BEGIN_DITAA ${1:export-file-name} -r -S -E\n${0}\n#+END_DITAA\n" "DITAA" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/dita" nil nil) ("desc" "#+DESCRIPTION: ${0}\n" "DESCRIPTION" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/desc" nil nil) ("block" "#+begin_$1 $2\n  $0\n#+end_$1\n" "#+begin_...#+end_" nil nil ((yas/indent-line (quote fixed)) (yas/wrap-around-region (quote nil))) "/home/cwebber/elisp/yasnippet-snippets/org-mode/block" nil nil) ("begin" "\\begin{$1}\n  $0\n\\end{$1}\n" "\\begin{...} ... \\end{...}" nil nil ((yas/indent-line (quote fixed)) (yas/wrap-around-region (quote nil))) "/home/cwebber/elisp/yasnippet-snippets/org-mode/begin" nil nil) ("author" "#+AUTHOR: ${1:`user-full-name`}\n" "Author" nil nil nil "/home/cwebber/elisp/yasnippet-snippets/org-mode/author" nil nil)))
  yas--load-directory-2("/home/cwebber/elisp/yasnippet-snippets/org-mode" org-mode)
  yas--load-directory-1("/home/cwebber/elisp/yasnippet-snippets/org-mode" org-mode nil)
  eval((yas--load-directory-1 "/home/cwebber/elisp/yasnippet-snippets/org-mode" (quote org-mode) (quote nil)))
  yas-load-directory("~/elisp/yasnippet-snippets/" t)
  yas--load-snippet-dirs(nil)
  byte-code("\306\307\310\311 \"..\b\2031.\n\203+.\312\313!\203..\314\315\b\"\210\2021.\316\317\320\"\210\321\322\306\"\210\2021.\314\323\311 \"\210\324 .\324 .\325\326.\"\210\324 .\324 ..\327\n!.\330 \210\316\331\332\n\203U.\333\202V.\334	\203^.\335\202_.\333$*\207" [snippet-editing-buffers errors interactive yas--tables yas--parents yas--menu-table nil remove-if-not #[(buffer) "r\bq\210	)\207" [buffer yas--editing-template] 1] buffer-list y-or-n-p "Some buffers editing live snippets, close them and proceed with reload? " mapc kill-buffer yas--message 1 "Aborted reload..." throw abort #[(buffer) "\301\211.\207" [yas--editing-template nil] 2] make-hash-table maphash #[(menu-symbol keymap) "\302\b\303	!\304#\207" [yas--minor-mode-menu menu-symbol define-key vector nil] 4] yas--load-snippet-dirs yas-direct-keymaps-reload 3 "Reloaded everything%s...%s." "" " (snippets will load just-in-time)" " (some errors, check *Messages*)" yas--scheduled-jit-loads] 5)
  yas-reload-all()
  yas--global-mode-reload-with-jit-maybe()
  run-hooks(yas-global-mode-hook yas-global-mode-on-hook)
  yas-global-mode(1)
  eval-buffer(#<buffer  *load*> nil "/home/cwebber/.config/emacs/modes/yasnippet.el" nil t)  ; Reading at buffer position 786
  load-with-code-conversion("/home/cwebber/.config/emacs/modes/yasnippet.el" "/home/cwebber/.config/emacs/modes/yasnippet.el" nil nil)
  load("/home/cwebber/.config/emacs/modes/yasnippet.el" nil nil t)
  load-file("~/.config/emacs/modes/yasnippet.el")
  eval((load-file "~/.config/emacs/modes/yasnippet.el") nil)
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp nil nil)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: yasnippet common lisp objects broken by recent emacs changes?
  2013-01-26 22:59 yasnippet common lisp objects broken by recent emacs changes? Christopher Allan Webber
@ 2013-01-26 23:36 ` Xue Fuqiao
  2013-01-27  0:29 ` Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Xue Fuqiao @ 2013-01-26 23:36 UTC (permalink / raw)
  To: Christopher Allan Webber; +Cc: Emacs Development

On Sat, 26 Jan 2013 16:59:47 -0600
Christopher Allan Webber <cwebber@dustycloud.org> wrote:

> ...however, there isn't any cl-set-getf method that's actually called or
> called in yasnippet itself... I wonder if this is something related to
> the way the cl-struct system works, and somethign missing there?

Have you tried `fset'?

-- 
Best regards, Xue Fuqiao.
http://www.emacswiki.org/emacs/XueFuqiao



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: yasnippet common lisp objects broken by recent emacs changes?
  2013-01-26 22:59 yasnippet common lisp objects broken by recent emacs changes? Christopher Allan Webber
  2013-01-26 23:36 ` Xue Fuqiao
@ 2013-01-27  0:29 ` Stefan Monnier
  2013-01-27  3:43   ` Christopher Allan Webber
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-01-27  0:29 UTC (permalink / raw)
  To: Christopher Allan Webber; +Cc: Emacs Development

>>>>> "Christopher" == Christopher Allan Webber <cwebber@dustycloud.org> writes:

> Heya all,
> I noticed that when I try to run yasnippet (running from git as fetched
> by el-get) recently I've been getting this error.
[...]
> Debugger entered--Lisp error: (void-function cl-set-getf)

I think the patch below will fix it (but please in the future report
those problem to bug-gnu-emacs@gnu.org (or via M-x report-emacs-bug) so
they get assigned a bug number).

I installed it into the emacs-24 branch, so it will appear on the trunk
"soonish".


        Stefan


=== modified file 'lisp/emacs-lisp/cl.el'
--- lisp/emacs-lisp/cl.el	2013-01-01 09:11:05 +0000
+++ lisp/emacs-lisp/cl.el	2013-01-26 23:15:12 +0000
@@ -713,6 +713,7 @@
   'cl--map-keymap-recursively "24.3")
 (define-obsolete-function-alias 'cl-map-intervals 'cl--map-intervals "24.3")
 (define-obsolete-function-alias 'cl-map-extents 'cl--map-overlays "24.3")
+(define-obsolete-function-alias 'cl-set-getf 'cl--set-getf "24.3")
 
 (defun cl-maclisp-member (item list)
   (declare (obsolete member "24.3"))



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: yasnippet common lisp objects broken by recent emacs changes?
  2013-01-27  0:29 ` Stefan Monnier
@ 2013-01-27  3:43   ` Christopher Allan Webber
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Allan Webber @ 2013-01-27  3:43 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Emacs Development

Stefan Monnier writes:

>>>>>> "Christopher" == Christopher Allan Webber <cwebber@dustycloud.org> writes:
>
>> Heya all,
>> I noticed that when I try to run yasnippet (running from git as fetched
>> by el-get) recently I've been getting this error.
> [...]
>> Debugger entered--Lisp error: (void-function cl-set-getf)
>
> I think the patch below will fix it (but please in the future report
> those problem to bug-gnu-emacs@gnu.org (or via M-x report-emacs-bug) so
> they get assigned a bug number).
>
> I installed it into the emacs-24 branch, so it will appear on the trunk
> "soonish".
>
>
>         Stefan
>
>
> === modified file 'lisp/emacs-lisp/cl.el'
> --- lisp/emacs-lisp/cl.el	2013-01-01 09:11:05 +0000
> +++ lisp/emacs-lisp/cl.el	2013-01-26 23:15:12 +0000
> @@ -713,6 +713,7 @@
>    'cl--map-keymap-recursively "24.3")
>  (define-obsolete-function-alias 'cl-map-intervals 'cl--map-intervals "24.3")
>  (define-obsolete-function-alias 'cl-map-extents 'cl--map-overlays "24.3")
> +(define-obsolete-function-alias 'cl-set-getf 'cl--set-getf "24.3")
>  
>  (defun cl-maclisp-member (item list)
>    (declare (obsolete member "24.3"))

Thank you!  And sorry, in the future I will email bug-gnu-emacs instead :)



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-01-27  3:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-26 22:59 yasnippet common lisp objects broken by recent emacs changes? Christopher Allan Webber
2013-01-26 23:36 ` Xue Fuqiao
2013-01-27  0:29 ` Stefan Monnier
2013-01-27  3:43   ` Christopher Allan Webber

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).