From: Bastien <bzg@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Aaron Ecay <aaronecay@gmail.com>, emacs-devel@gnu.org
Subject: Re: Using `save-window-excursion' instead of `save-excursion' for `comment-region'?
Date: Fri, 06 Dec 2013 10:49:17 +0100 [thread overview]
Message-ID: <8738m6z4v6.fsf@bzg.ath.cx> (raw)
In-Reply-To: <jwvr49rccec.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 05 Dec 2013 14:45:29 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I think your analysis is exactly right, and the reason why
> save-window-excursion doesn't exhibit the problem is because
> save-window-excursion does not save-excursion in the current buffer.
> I.e. paradoxically it's because it "preserves less" rather than because
> it "preserves more". Replacing the save-excursion with
> save-current-buffer would probably work as well.
I see, thanks.
I've fixed the problem in Org by creating `org-comment-dwim',
which use comment-dwim when outside a source block, and
`org-babel-do-in-edit-buffer' (directly, not wrapped into
comment-region) when the point is within a buffer.
Aaron, thanks for your input and for testing this heavily.
--
Bastien
next prev parent reply other threads:[~2013-12-06 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 10:18 Using `save-window-excursion' instead of `save-excursion' for `comment-region'? Bastien
2013-12-05 11:46 ` martin rudalics
2013-12-05 12:49 ` Andreas Röhler
2013-12-05 18:29 ` Stefan Monnier
2013-12-05 18:43 ` Bastien
2013-12-05 19:05 ` Aaron Ecay
2013-12-05 19:45 ` Stefan Monnier
2013-12-06 9:49 ` Bastien [this message]
2013-12-06 9:58 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738m6z4v6.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=aaronecay@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).