unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Cc: Bastien <bzg@altern.org>
Subject: Re: Using `save-window-excursion' instead of `save-excursion' for `comment-region'?
Date: Thu, 05 Dec 2013 13:49:34 +0100	[thread overview]
Message-ID: <52A0765E.5050701@online.de> (raw)
In-Reply-To: <87y53zk3dx.fsf@bzg.ath.cx>

Am 05.12.2013 11:18, schrieb Bastien:
> In Org buffer, you can comment code within source blocks.  This opens
> a new buffer, insert the code there, comment it, and insert the buffer
> contents back into Org's buffer.
>
> With the current `comment-region' function, point is lost when Org
> goes back to the org buffer.  Using `save-window-excursion' instead
> of `save-excursion' fixes the problem.
>
> Are you aware of problems that this change may trigger?
>
> I cannot think of any, but I'm always a bit cautious when using
> `save-window-excursion'.
>
> Thanks for your feedback,
>

Hi Bastien,

last time I've seen in, indirect buffers were used, which would be worth mentioning.

Andreas



  parent reply	other threads:[~2013-12-05 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 10:18 Using `save-window-excursion' instead of `save-excursion' for `comment-region'? Bastien
2013-12-05 11:46 ` martin rudalics
2013-12-05 12:49 ` Andreas Röhler [this message]
2013-12-05 18:29 ` Stefan Monnier
2013-12-05 18:43   ` Bastien
2013-12-05 19:05     ` Aaron Ecay
2013-12-05 19:45       ` Stefan Monnier
2013-12-06  9:49         ` Bastien
2013-12-06  9:58           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A0765E.5050701@online.de \
    --to=andreas.roehler@online.de \
    --cc=bzg@altern.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).