unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Native vs Elisp JSON key serialisation
@ 2020-07-28 18:16 Basil L. Contovounesios
  2020-12-05 19:34 ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Basil L. Contovounesios @ 2020-07-28 18:16 UTC (permalink / raw)
  To: emacs-devel

While looking at bug#42545, I noticed some inconsistencies in object key
serialisation between json-encode and json-serialize.

When serialising hash tables:
- json-encode translates the keys 'foo, :foo, and "foo" to "foo"
- json-serialize translates "foo" to "foo"
  (and rejects symbols as keys)

I don't have a problem with this; it makes sense to me that json.c is
stricter, and json.el is older so has more backward compatibility to
maintain.  In other words, the two implementations are sufficiently
consistent IMO.

When serialising alists:
- json-encode translates 'foo, :foo, and "foo" to "foo"
- json-serialize translates 'foo to "foo", and :foo to ":foo"
  (and rejects strings as keys)

Here the two implementations are inconsistent.  Should the older
json-encode also translate :foo to ":foo", or should the newer and more
prominently (in the Elisp manual) documented json-serialize translate
:foo to "foo"?

When serialising plists:
- json-encode translates :foo to "foo" (and interprets 'foo and "foo" as
  starting an array rather than associative object)
- json-serialize translates 'foo and :foo to "foo"
  (and rejects strings as keys)

Here the two implementations are again inconsistent.  Should json-encode
also accept plists with non-keyword symbols as keys, or should
json-serialize accept only keywords as keys?

In both cases, I'm inclined to change json-encode to be more consistent
with json-serialize as the more authoritative of the two.  Either way, I
think the two implementations should be as consistent and thus
interchangeable as possible.  WDYT?

-- 
Basil



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-05 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 18:16 Native vs Elisp JSON key serialisation Basil L. Contovounesios
2020-12-05 19:34 ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).