From: Daniel Semyonov <daniel@dsemy.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: [NonGNU ELPA] New packages: Vcomplete, swsw
Date: Mon, 23 May 2022 14:36:11 +0300 [thread overview]
Message-ID: <8735h0scpg.fsf@dsemy.com> (raw)
In-Reply-To: <87mtf9lfff.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 22 May 2022 16:07:00 +0000")
>>>>> Philip Kaludercic writes:
>> In any case, I haven't tested this integration in a while, so I
>> think it would make more sense to completely exclude
>> 'vcomplete-embark.el' for now (this integration broke in the past
>> due to changes to Embark and Vcomplete, and might be broken in
>> some way now as I don't currently use Embark). I'll do some
>> testing in the next few days.
> In that case I'd advise just adding it to a .elpaignore so that
> you don't have to change the package specification upstream.
I've done some basic testing and it seems that Embark had changed pretty
drastically, and I would have to make significant changes to make this
integration work with the current version.
Since I'm not using Embark anymore, I've decided to remove this
completely.
>>> - Could the vector key syntax ([?\C-a]) be replaced with a (kbd
>>> "C-a")? I think the general trend nowadays is towards the
>>> latter, and more people are familiar with it.
>>
>> Now that you mention it, since it's just an example, wouldn't it
>> make more sense to use 'keymap-set' for it? (Although technically
>> both packages could be used with an Emacs version that doesn't
>> support 'keymap-set').
> I wouldn't, as your package-dependency specification indicates
> that the minimal version is 25.1, and no release of Emacs has been
> made with the new keymap functions/macros. It is easy for
> enthusiasts to forget that most people are not tracking the master
> branch.
Oh, I incorrectly remembered that 'keymap-set' and friends were included
in Emacs 28.1. In any case, I updated the commentary of both packages
to use 'kbd' instead of the vector key syntax.
> No, the last commit that bumps the version tag is always the one
> used. I can push the specifications, though I will wait for a bit
> to see if anyone wants to comment on anything discussed here.
I bumped the version for both packages now, so they should be
completely ready for inclusion I think.
Thanks,
Daniel
next prev parent reply other threads:[~2022-05-23 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 10:58 [NonGNU ELPA] New packages: Vcomplete, swsw Daniel Semyonov
2022-05-22 11:48 ` Philip Kaludercic
2022-05-22 15:55 ` Daniel Semyonov
2022-05-22 16:07 ` Philip Kaludercic
2022-05-23 11:36 ` Daniel Semyonov [this message]
2022-05-22 16:29 ` Stefan Monnier
2022-05-23 11:45 ` Daniel Semyonov
2022-05-24 19:47 ` Philip Kaludercic
2022-05-24 20:16 ` Daniel Semyonov
2022-05-25 6:26 ` Philip Kaludercic
2022-05-25 13:34 ` Daniel Semyonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735h0scpg.fsf@dsemy.com \
--to=daniel@dsemy.com \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).