From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Semyonov Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New packages: Vcomplete, swsw Date: Mon, 23 May 2022 14:36:11 +0300 Message-ID: <8735h0scpg.fsf@dsemy.com> References: <875ylx4yvn.fsf@dsemy.com> <87h75hyehx.fsf@posteo.net> <87sfp15zp1.fsf@dsemy.com> <87mtf9lfff.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2849"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 13:40:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6QF-0000Ws-Tq for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 13:40:28 +0200 Original-Received: from localhost ([::1]:46940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt6QE-0007NB-KY for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 07:40:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6MU-0005yJ-8m for emacs-devel@gnu.org; Mon, 23 May 2022 07:36:34 -0400 Original-Received: from dsemy.com ([46.23.89.208]:36546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6MG-0003K3-4L for emacs-devel@gnu.org; Mon, 23 May 2022 07:36:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=sNpmJNHfZjI53 0whoYTgKHorsciEpzgVjJQ5B6InPWo=; h=in-reply-to:date:references: subject:cc:to:from; d=dsemy.com; b=OOsnBKxJKayZa33QXwu6cTLeK7zGY7uxzut +LIMth55X+OSsxq/CPRwGolRgLsJ+NAzhv0XLT/MVKaGkc2wC14YDKlHqgkpzapcrvIQKw S/f9XTwC+7RmsAookFrXtb2ShJiiXl9oMhrKtfdpVpKIWDZLCT68qSKQ1/rYs4njYmILTQ VPOXxdzhxZ2a8vkQXPkxFsokr+yzSRmOpovum8mpI9esawuJgl5HfNnOc++dsV2uNnx1yy cCBRhsIRBa7fiQeoPFpgbZ49aDytOqUlX7KmEURGJKm8YV65+vZWjY7PCLR2wFeVyDQOej U448BBbllfkvG35hpr0iiKyRC0g== Original-Received: from coldharbour (bzq-79-183-62-6.red.bezeqint.net [79.183.62.6]) by dsemy.com (OpenSMTPD) with ESMTPSA id 5af2ac0d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 May 2022 13:36:12 +0200 (CEST) Original-Received: from localhost (coldharbour [local]) by coldharbour (OpenSMTPD) with ESMTPA id 47a404ab; Mon, 23 May 2022 11:36:11 +0000 (UTC) In-Reply-To: <87mtf9lfff.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 22 May 2022 16:07:00 +0000") Received-SPF: pass client-ip=46.23.89.208; envelope-from=daniel@dsemy.com; helo=dsemy.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290145 Archived-At: >>>>> Philip Kaludercic writes: >> In any case, I haven't tested this integration in a while, so I >> think it would make more sense to completely exclude >> 'vcomplete-embark.el' for now (this integration broke in the past >> due to changes to Embark and Vcomplete, and might be broken in >> some way now as I don't currently use Embark). I'll do some >> testing in the next few days. > In that case I'd advise just adding it to a .elpaignore so that > you don't have to change the package specification upstream. I've done some basic testing and it seems that Embark had changed pretty drastically, and I would have to make significant changes to make this integration work with the current version. Since I'm not using Embark anymore, I've decided to remove this completely. >>> - Could the vector key syntax ([?\C-a]) be replaced with a (kbd >>> "C-a")? I think the general trend nowadays is towards the >>> latter, and more people are familiar with it. >> >> Now that you mention it, since it's just an example, wouldn't it >> make more sense to use 'keymap-set' for it? (Although technically >> both packages could be used with an Emacs version that doesn't >> support 'keymap-set'). > I wouldn't, as your package-dependency specification indicates > that the minimal version is 25.1, and no release of Emacs has been > made with the new keymap functions/macros. It is easy for > enthusiasts to forget that most people are not tracking the master > branch. Oh, I incorrectly remembered that 'keymap-set' and friends were included in Emacs 28.1. In any case, I updated the commentary of both packages to use 'kbd' instead of the vector key syntax. > No, the last commit that bumps the version tag is always the one > used. I can push the specifications, though I will wait for a bit > to see if anyone wants to comment on anything discussed here. I bumped the version for both packages now, so they should be completely ready for inclusion I think. Thanks, Daniel