unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: "Mattias Engdegård" <mattiase@acm.org>
Subject: Re: master e9e807e: Don't remove notify descriptor that is already gone
Date: Tue, 16 Apr 2019 09:04:56 +0200	[thread overview]
Message-ID: <871s2277mv.fsf@gmx.de> (raw)
In-Reply-To: <20190415083339.64FE620536@vcs0.savannah.gnu.org> (unknown@unknown.invalid's message of "Mon, 15 Apr 2019 04:33:38 -0400 (EDT)")

Unknown <unknown@unknown.invalid> writes:

Hi Mattias,

>     Don't remove notify descriptor that is already gone
>
>     * lisp/autorevert.el (auto-revert-use-notify, auto-revert-mode,
>     global-auto-revert-mode, auto-revert-notify-rm-watch,
>     auto-revert-notify-add-watch, auto-revert-notify-handler,
>     auto-revert-notify-rm-watch-callback):
>     Don't remove a notify descriptor after receiving a `stopped' notification
>     event, because the descriptor is then already gone and any attempt to
>     remove it causes a recursive call to `auto-revert-notify-handler'.

Thanks for this!

I haven't tested thoroughly yet, but wouldn't it suffice if in
auto-revert-notify-rm-watch there is just the test

(when (file-notify-valid-p auto-revert-notify-watch-descriptor)

instead of

(when auto-revert-notify-watch-descriptor

Best regards, Michael.



       reply	other threads:[~2019-04-16  7:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190415083338.9906.18508@vcs0.savannah.gnu.org>
     [not found] ` <20190415083339.64FE620536@vcs0.savannah.gnu.org>
2019-04-16  7:04   ` Michael Albinus [this message]
2019-04-16 13:31     ` master e9e807e: Don't remove notify descriptor that is already gone Mattias Engdegård
2019-04-19 14:56       ` Michael Albinus
2019-04-20 10:20         ` Mattias Engdegård
2019-04-22  8:37           ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s2277mv.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).