From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master e9e807e: Don't remove notify descriptor that is already gone Date: Tue, 16 Apr 2019 09:04:56 +0200 Message-ID: <871s2277mv.fsf@gmx.de> References: <20190415083338.9906.18508@vcs0.savannah.gnu.org> <20190415083339.64FE620536@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149529"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 09:05:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGI9i-000cjb-J3 for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 09:05:22 +0200 Original-Received: from localhost ([127.0.0.1]:60403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGI9h-0007bL-F4 for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 03:05:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGI9X-0007ZD-1Q for emacs-devel@gnu.org; Tue, 16 Apr 2019 03:05:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGI9V-0001BH-34 for emacs-devel@gnu.org; Tue, 16 Apr 2019 03:05:10 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:37511) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGI9U-00017C-OE for emacs-devel@gnu.org; Tue, 16 Apr 2019 03:05:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1555398299; bh=y5abfjvsA/QClShSbCjJ11xMaGQ7jDDwz8JwWVGUECc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=eV5F9XGAoaWxMNRByCHn4ML+p1rJ4NeNVabdFOBnfI6Aom6T3PSg3Mx5yesVNxiQ6 BHiiKGY8JQuckF8XgSjbMDfCfVJ8iwXeLCgS7ZIUpOyKv3zzeGh8fcTXijppFYQAxg lTQRmi4pmh0YrmuiX+/dSds0F48NDAb5FiTbQZNs= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([213.220.146.33]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MBmvH-1h6cyz36k3-00ApWA; Tue, 16 Apr 2019 09:04:58 +0200 In-Reply-To: <20190415083339.64FE620536@vcs0.savannah.gnu.org> (unknown@unknown.invalid's message of "Mon, 15 Apr 2019 04:33:38 -0400 (EDT)") X-Provags-ID: V03:K1:r0iBcNDhoZciGwq6vIhmeUES/GsoBzMVLO86k8r4O34WHK/AszS UqnvAyBWSoP3ZLf4wkPiK047PUI9tCaXtk50v8bC2RrlryQ3hRVxOdtpQCbzck7b5hWYg/5 P1eijQWU+QfIpd1LRdq1ndKJFpG89n2JB01OOs+qRdRxfp3Y/bHRA3gDYJS+wsxxD/H0mXi KBOXvCSLFVAX4lU/Kkr9A== X-UI-Out-Filterresults: notjunk:1;V03:K0:an9MP9QLN3c=:Ryhr5T4+yTkordRJikgW3P n5fHfuBm0Mz8J68yoPubUsFMsl9r+Q5fvEtK8c9d9SQRL4opvT7RJD67RpG2r2YceEr2bWBKv fm0pzkb1ZzHTPr7Nmav1DNZs5HhmtuZSVDtvfxAq6hJg/v66NZKpz+SsZ6cJzQlqkyr/g4RwE xCb7OaOwuACwo1o1lsBsH5GFg1KoWhxlzjKqTFuY+rTIyaki4OnEPSczVpwn6c5uv/AY6DY9c SMv/3hkhw30J8O8DiQ869HZVkrYtirTsVO9i+mFLz1b0EH+NOfHalON+t/odYFl37ORhqodnb zHzQrD0riVWp0A3T5i07es1I6Rehx8ww7PCFVNFCQW8yK5Fhdey3zJ0FhC5VVMAcdqPkZONq1 YsvdUEYqVlzu5cS4rP4lYNZ1hFxYHwPwgY7ocgyqM7ZRZlonqfnYuiJG4hi2lzQrvZpSm9fWY ckYygsyEJ4u/x0Ve2+/otLeu/OC4CmfxC2w3D78yzCKyP9K1gArryoMl8t7s3JzCeHzW6+nzL VM7Wsq3KoFAUjU7Z/TYFz5BUJJyXv/j2ViZHLaLe419hf+Y0eHi4wm9XZpCYJA2EnOlXfn012 pfVumznbQC+N3Fl0t2E7sgBZGYbgVCta+NE/BTZtSUJhh75X1tA9pBge2uoiz0DLUiuAk0YpC NbfHSeysCuz2WW7OkMjkOqdJcpXTHXcv6D7qMOEB93BHfmP5y/Z3Kd3ktq3JWgqbbEl09oWw/ SlrJDdPcSmA+hlonVDR3EN41Zkm8G18S+2vpZndXamuMLc/lEHxqorYARRPEAZJw9GzB2R5k X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235509 Archived-At: Unknown writes: Hi Mattias, > Don't remove notify descriptor that is already gone > > * lisp/autorevert.el (auto-revert-use-notify, auto-revert-mode, > global-auto-revert-mode, auto-revert-notify-rm-watch, > auto-revert-notify-add-watch, auto-revert-notify-handler, > auto-revert-notify-rm-watch-callback): > Don't remove a notify descriptor after receiving a `stopped' notific= ation > event, because the descriptor is then already gone and any attempt t= o > remove it causes a recursive call to `auto-revert-notify-handler'. Thanks for this! I haven't tested thoroughly yet, but wouldn't it suffice if in auto-revert-notify-rm-watch there is just the test (when (file-notify-valid-p auto-revert-notify-watch-descriptor) instead of (when auto-revert-notify-watch-descriptor Best regards, Michael.