unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Breakage by commit "779bc886f9 * Improve detection of Git submodules"
Date: Fri, 15 May 2020 21:45:52 +0200	[thread overview]
Message-ID: <871rnluglr.fsf@gnu.org> (raw)
In-Reply-To: <a704d1ee-41dc-2c39-9895-9861f87f08b9@yandex.ru> (Dmitry Gutov's message of "Fri, 15 May 2020 22:11:39 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 15.05.2020 22:03, Tassilo Horn wrote:
>> Hi Dmitry,
>> since the commit in the subject, I get errors like the below when
>> finding a file in a git repository:
>
> Thanks, should be fixed now.

Nope, sorry.  With emacs -Q evaling

(progn
  (require 'project)
  (project-try-vc "~/Repos/el/emacs/lisp/net"))

gives

Debugger entered--Lisp error: (file-missing "Opening input file" "No such file or directory" "/home/horn/Repos/el/emacs/lisp/net/.git")
  insert-file-contents("/home/horn/Repos/el/emacs/lisp/net/.git")
  project-try-vc("~/Repos/el/emacs/lisp/net")
  (progn (require 'project) (project-try-vc "~/Repos/el/emacs/lisp/net"))

I've edebugged, and the problem is that

(let ((default-directory "~/Repos/el/emacs/lisp/net"))
  (vc-root-dir)) ;=> nil

That's because `vc-deduce-backend' returns nil.  It only looks at
default-directory when in dired-mode, shell-mode, or compilation-mode...
I wonder why that's restricted and not the fallback case...

Bye,
Tassilo



  reply	other threads:[~2020-05-15 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 19:03 Breakage by commit "779bc886f9 * Improve detection of Git submodules" Tassilo Horn
2020-05-15 19:11 ` Dmitry Gutov
2020-05-15 19:45   ` Tassilo Horn [this message]
2020-05-15 21:03     ` Dmitry Gutov
2020-05-16  7:15       ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rnluglr.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).