From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Breakage by commit "779bc886f9 * Improve detection of Git submodules" Date: Fri, 15 May 2020 21:45:52 +0200 Message-ID: <871rnluglr.fsf@gnu.org> References: <87mu69xbq0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 21:46:32 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZgHu-000Mlb-Vw for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 21:46:30 +0200 Original-Received: from localhost ([::1]:57174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZgHu-00017x-1Z for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 15:46:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZgHN-0000gp-4M for emacs-devel@gnu.org; Fri, 15 May 2020 15:45:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48525) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZgHL-0005VE-W8; Fri, 15 May 2020 15:45:56 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:59695) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jZgHL-0007d9-L6; Fri, 15 May 2020 15:45:55 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 106EB27C0054; Fri, 15 May 2020 15:45:55 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 15 May 2020 15:45:55 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleekgddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnheptd elieffkeeuffduueeffefhiedtjeeutdeuveegfffgtdejleekheegkeetkeevnecukfhp peelfedrvdefiedrudegtddrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfh grshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8c3f.dip0.t-ipconnect.de [93.236.140.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 06A6B306635C; Fri, 15 May 2020 15:45:53 -0400 (EDT) Mail-Followup-To: Dmitry Gutov , emacs-devel@gnu.org In-Reply-To: (Dmitry Gutov's message of "Fri, 15 May 2020 22:11:39 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250422 Archived-At: Dmitry Gutov writes: > On 15.05.2020 22:03, Tassilo Horn wrote: >> Hi Dmitry, >> since the commit in the subject, I get errors like the below when >> finding a file in a git repository: > > Thanks, should be fixed now. Nope, sorry. With emacs -Q evaling (progn (require 'project) (project-try-vc "~/Repos/el/emacs/lisp/net")) gives Debugger entered--Lisp error: (file-missing "Opening input file" "No such file or directory" "/home/horn/Repos/el/emacs/lisp/net/.git") insert-file-contents("/home/horn/Repos/el/emacs/lisp/net/.git") project-try-vc("~/Repos/el/emacs/lisp/net") (progn (require 'project) (project-try-vc "~/Repos/el/emacs/lisp/net")) I've edebugged, and the problem is that (let ((default-directory "~/Repos/el/emacs/lisp/net")) (vc-root-dir)) ;=> nil That's because `vc-deduce-backend' returns nil. It only looks at default-directory when in dired-mode, shell-mode, or compilation-mode... I wonder why that's restricted and not the fallback case... Bye, Tassilo