* Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el
[not found] ` <20201219141040.5A4F020AE6@vcs0.savannah.gnu.org>
@ 2021-01-05 13:50 ` Robert Pluim
2021-01-05 14:27 ` Basil L. Contovounesios
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2021-01-05 13:50 UTC (permalink / raw)
To: emacs-devel; +Cc: Basil L. Contovounesios
blc@savannah.gnu.org (Basil L. Contovounesios) writes:
> branch: master
> commit 8f91fe3063c1a4523520624054458229cc376d9b
> Author: Basil L. Contovounesios <contovob@tcd.ie>
> Commit: Basil L. Contovounesios <contovob@tcd.ie>
>
> Set indent-tabs-mode for c-mode in .dir-locals.el
>
> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode
> policy. (Bug#34765)
What existing 'indent-tabs-mode' policy? Last time this came up I
thought it had been decided that there wasn't one for C, only for
elisp. (and I donʼt see what it has to do with that bug #)
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el
2021-01-05 13:50 ` master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el Robert Pluim
@ 2021-01-05 14:27 ` Basil L. Contovounesios
2021-01-05 15:06 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: Basil L. Contovounesios @ 2021-01-05 14:27 UTC (permalink / raw)
To: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> blc@savannah.gnu.org (Basil L. Contovounesios) writes:
>
>> branch: master
>> commit 8f91fe3063c1a4523520624054458229cc376d9b
>> Author: Basil L. Contovounesios <contovob@tcd.ie>
>> Commit: Basil L. Contovounesios <contovob@tcd.ie>
>>
>> Set indent-tabs-mode for c-mode in .dir-locals.el
>>
>> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode
>> policy. (Bug#34765)
>
> What existing 'indent-tabs-mode' policy? Last time this came up I
> thought it had been decided that there wasn't one for C, only for
> elisp.
I have seen Eli and others request several times that C code remain
indented with a mixture of tabs and spaces, aka the default value of
indent-tabs-mode. By comparison, indent-tabs-mode is set to nil for
Elisp code, although not all contributors follows this convention.
So by "existing policy" I was referring both to our C convention, and
the fact that indent-tabs-mode defaults to t anyway. Making this
explicit in .dir-locals.el is for the benefit of people like myself who
change the default value of indent-tabs-mode in their config.
> (and I donʼt see what it has to do with that bug #)
I originally included the .dir-locals.el change as part of my patch for
that bug #, but was asked to commit it separately. I try to always link
to any relevant discussion/review/approval in my patches for posterity.
--
Basil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el
2021-01-05 14:27 ` Basil L. Contovounesios
@ 2021-01-05 15:06 ` Robert Pluim
2021-01-05 15:35 ` Basil L. Contovounesios
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2021-01-05 15:06 UTC (permalink / raw)
To: Basil L. Contovounesios; +Cc: emacs-devel
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Robert Pluim <rpluim@gmail.com> writes:
>
>> blc@savannah.gnu.org (Basil L. Contovounesios) writes:
>>
>>> branch: master
>>> commit 8f91fe3063c1a4523520624054458229cc376d9b
>>> Author: Basil L. Contovounesios <contovob@tcd.ie>
>>> Commit: Basil L. Contovounesios <contovob@tcd.ie>
>>>
>>> Set indent-tabs-mode for c-mode in .dir-locals.el
>>>
>>> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode
>>> policy. (Bug#34765)
>>
>> What existing 'indent-tabs-mode' policy? Last time this came up I
>> thought it had been decided that there wasn't one for C, only for
>> elisp.
>
> I have seen Eli and others request several times that C code remain
> indented with a mixture of tabs and spaces, aka the default value of
> indent-tabs-mode. By comparison, indent-tabs-mode is set to nil for
> Elisp code, although not all contributors follows this convention.
>
Iʼve seen Eli and others request that people not randomly reformat
existing code outside changes they're making according to their
setting of indent-tabs-mode, which is not quite the same thing. I
donʼt think we have an explicit policy written down anywhere.
> So by "existing policy" I was referring both to our C convention, and
> the fact that indent-tabs-mode defaults to t anyway. Making this
> explicit in .dir-locals.el is for the benefit of people like myself who
> change the default value of indent-tabs-mode in their config.
>
>> (and I donʼt see what it has to do with that bug #)
>
> I originally included the .dir-locals.el change as part of my patch for
> that bug #, but was asked to commit it separately. I try to always link
> to any relevant discussion/review/approval in my patches for posterity.
OK
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el
2021-01-05 15:06 ` Robert Pluim
@ 2021-01-05 15:35 ` Basil L. Contovounesios
0 siblings, 0 replies; 4+ messages in thread
From: Basil L. Contovounesios @ 2021-01-05 15:35 UTC (permalink / raw)
To: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Robert Pluim <rpluim@gmail.com> writes:
>>
>>> blc@savannah.gnu.org (Basil L. Contovounesios) writes:
>>>
>>>> branch: master
>>>> commit 8f91fe3063c1a4523520624054458229cc376d9b
>>>> Author: Basil L. Contovounesios <contovob@tcd.ie>
>>>> Commit: Basil L. Contovounesios <contovob@tcd.ie>
>>>>
>>>> Set indent-tabs-mode for c-mode in .dir-locals.el
>>>>
>>>> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode
>>>> policy. (Bug#34765)
>>>
>>> What existing 'indent-tabs-mode' policy? Last time this came up I
>>> thought it had been decided that there wasn't one for C, only for
>>> elisp.
>>
>> I have seen Eli and others request several times that C code remain
>> indented with a mixture of tabs and spaces, aka the default value of
>> indent-tabs-mode. By comparison, indent-tabs-mode is set to nil for
>> Elisp code, although not all contributors follows this convention.
>>
>
> Iʼve seen Eli and others request that people not randomly reformat
> existing code outside changes they're making according to their
> setting of indent-tabs-mode, which is not quite the same thing.
Indeed, they're not the same, and they're not mutually exclusive either.
> I donʼt think we have an explicit policy written down anywhere.
Until now. ;) (unless you count the mailing lists)
--
Basil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-05 15:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201219141039.21364.8125@vcs0.savannah.gnu.org>
[not found] ` <20201219141040.5A4F020AE6@vcs0.savannah.gnu.org>
2021-01-05 13:50 ` master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el Robert Pluim
2021-01-05 14:27 ` Basil L. Contovounesios
2021-01-05 15:06 ` Robert Pluim
2021-01-05 15:35 ` Basil L. Contovounesios
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).