unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Gregory Heytings <gregory@heytings.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	 rms@gnu.org,  drew.adams@oracle.com, larsi@gnus.org,
	 emacs-devel@gnu.org
Subject: Re: [External] : Re: master 513c5d827d: Use `format-prompt' in
Date: Mon, 05 Sep 2022 18:10:04 +0200	[thread overview]
Message-ID: <871qsperab.fsf@gmail.com> (raw)
In-Reply-To: <0b2303e39250624d54a6@heytings.org> (Gregory Heytings's message of "Mon, 05 Sep 2022 16:02:36 +0000")

>>>>> On Mon, 05 Sep 2022 16:02:36 +0000, Gregory Heytings <gregory@heytings.org> said:

    >>> My admittedly not well-calibrated lisp tasteʼoʼmeter doesnʼt find
    >>> 
    >>> (format-prompt "Prompt" nil :default "all")
    >>> 
    >>> all that appealing either
    >> 
    >> <Shrug> Then I hope someone will come up with a better idea.
    >> 
    >> My point is that using format-prompt obfuscates the code to some
    >> degree, and we should try to find a way of avoiding that, while
    >> keeping its advantages.
    >> 

    Gregory> FWIW, I'm not sure using minibuffer-default-prompt-format is optimal
    Gregory> in this specific case.  Before the change the prompt said:

    Gregory> Character (Unicode name or hex, default all):

    Gregory> Now it says:

    Gregory> Unicode name, single char, or hex (default all):

    Gregory> or, with minibuffer-default-prompt-format set to "":

My understanding is that if you break it, you get to keep both pieces.

    Gregory> Unicode name, single char, or hex:

    Gregory> IMO, the original prompt was much clearer, and I don't think those who
    Gregory> customized minibuffer-default-prompt-format would have protested that
    Gregory> this specific prompt does not obey their customization: "Unicode name
    Gregory> or hex, default all" is an explanation about the kind of input that is
    Gregory> expected, like the one we have for C-x 8 RET, which says:

I think Iʼve reached my limit on this issue. Patch away to your
heartʼs content.

Robert
-- 



  reply	other threads:[~2022-09-05 16:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-03  9:15 master 513c5d827d: Use `format-prompt' in Eli Zaretskii
2022-09-03  9:22 ` Lars Ingebrigtsen
2022-09-03  9:38   ` Eli Zaretskii
2022-09-03  9:45     ` Lars Ingebrigtsen
2022-09-03  9:56       ` Eli Zaretskii
2022-09-03 15:50       ` [External] : " Drew Adams
2022-09-05  4:04         ` Richard Stallman
2022-09-05  8:26           ` Robert Pluim
2022-09-05 11:42             ` Eli Zaretskii
2022-09-05 11:54               ` Robert Pluim
2022-09-05 12:19                 ` Eli Zaretskii
2022-09-05 12:29                   ` Robert Pluim
2022-09-05 12:33                     ` Eli Zaretskii
2022-09-05 16:02                       ` Gregory Heytings
2022-09-05 16:10                         ` Robert Pluim [this message]
2022-09-06  4:16               ` Richard Stallman
2022-09-06 12:37                 ` Eli Zaretskii
2022-09-07  2:23                   ` Richard Stallman
2022-09-07 10:03                     ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qsperab.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=drew.adams@oracle.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).