From: Stephen Leake <stephen_leake@stephe-leake.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>,
Emacs developers <emacs-devel@gnu.org>,
Markus Triska <triska@metalevel.at>,
21766@debbugs.gnu.org
Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace
Date: Tue, 27 Oct 2015 20:51:42 -0500 [thread overview]
Message-ID: <86wpu77ob5.fsf@stephe-leake.org> (raw)
In-Reply-To: <CAAeL0SQ76tmxLV112FkGrAKmZxBcdxP_D783reO3r_WdsYy9zA@mail.gmail.com> (Juanma Barranquero's message of "Tue, 27 Oct 2015 17:03:20 +0100")
Juanma Barranquero <lekktu@gmail.com> writes:
> This will be my first ERT test, so, does the following (attached, because
> Gmail) patch look acceptable?
Looks good to me, except see below.
> And, it is possible to commit a file with trailing whitespace?
Yes, but it's also very easy to lose it, thus breaking the test. I
suggest instead to save the file without extra whitespace, and add code
to the test to insert the extra whitespace. That way you can also add
comments about why this test exists, etc.
--
-- Stephe
next prev parent reply other threads:[~2015-10-28 1:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2si4xfcv5.fsf@metalevel.at>
[not found] ` <CAAeL0SQ2X62q1YWEdTjj4Tkh6=mTRo6EmJmY-4F0fE0bgm8JyA@mail.gmail.com>
[not found] ` <mvm611shegz.fsf@hawking.suse.de>
[not found] ` <CAAeL0SS+SHEA=bqH4aTf6WfzzvcmRXkZ8djypAHG5jckCJVZdg@mail.gmail.com>
[not found] ` <mvmziz4fxug.fsf@hawking.suse.de>
[not found] ` <CAAeL0SRYta+ZF2BWq7mYWb8-0-fpUNS5a1QOr5Dig_P3Z6MP+g@mail.gmail.com>
2015-10-27 16:03 ` bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Juanma Barranquero
2015-10-28 1:51 ` Stephen Leake [this message]
2015-10-28 9:08 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wpu77ob5.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=21766@debbugs.gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=schwab@suse.de \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).