From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: bug#21766: 25.0.50; delete-trailing-whitespace sometimes deletes non-whitespace Date: Tue, 27 Oct 2015 20:51:42 -0500 Message-ID: <86wpu77ob5.fsf@stephe-leake.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445997154 5243 80.91.229.3 (28 Oct 2015 01:52:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Oct 2015 01:52:34 +0000 (UTC) Cc: Andreas Schwab , Emacs developers , Markus Triska , 21766@debbugs.gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 28 02:52:22 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrFuV-0005Gs-Od for ged-emacs-devel@m.gmane.org; Wed, 28 Oct 2015 02:52:19 +0100 Original-Received: from localhost ([::1]:35172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrFuV-0001LS-0i for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2015 21:52:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrFuH-0001LL-Hv for emacs-devel@gnu.org; Tue, 27 Oct 2015 21:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrFuE-0000Au-Ab for emacs-devel@gnu.org; Tue, 27 Oct 2015 21:52:05 -0400 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:42174) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZrFuE-0000Aq-4p for emacs-devel@gnu.org; Tue, 27 Oct 2015 21:52:02 -0400 Original-Received: (qmail 18260 invoked by uid 0); 28 Oct 2015 01:51:59 -0000 Original-Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy7.mail.unifiedlayer.com with SMTP; 28 Oct 2015 01:51:59 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw3 with id aXrl1r00s2UdiVW01XroVm; Wed, 28 Oct 2015 01:51:58 -0600 X-Authority-Analysis: v=2.1 cv=Zs1+dbLG c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=5lJygRwiOn0A:10 a=pGLkceISAAAA:8 a=Ix5xV5TN6PjERupaXpEA:9 Original-Received: from [76.218.37.33] (port=58835 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZrFtz-0006KM-DV; Tue, 27 Oct 2015 19:51:47 -0600 In-Reply-To: (Juanma Barranquero's message of "Tue, 27 Oct 2015 17:03:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 70.40.196.235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192767 Archived-At: Juanma Barranquero writes: > This will be my first ERT test, so, does the following (attached, because > Gmail) patch look acceptable? Looks good to me, except see below. > And, it is possible to commit a file with trailing whitespace? Yes, but it's also very easy to lose it, thus breaking the test. I suggest instead to save the file without extra whitespace, and add code to the test to insert the extra whitespace. That way you can also add comments about why this test exists, etc. -- -- Stephe