unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master e4e9a7c: * lisp/startup.el: Let-bind browse-url-browser-function instead of setq-local
       [not found] ` <20211212174921.87A7220A0A@vcs0.savannah.gnu.org>
@ 2021-12-12 19:23   ` Stefan Monnier
  2021-12-12 19:34     ` Juri Linkov
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2021-12-12 19:23 UTC (permalink / raw)
  To: emacs-devel; +Cc: Juri Linkov

> -	    ,(lambda (_button) (browse-url "https://www.gnu.org/software/emacs/"))
> +	    ,(lambda (_button)
> +               (let ((browse-url-browser-function 'eww-browse-url))
> +                 (browse-url "https://www.gnu.org/software/emacs/")))

What's the difference between this and directly calling (eww-browse-url "...")?


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master e4e9a7c: * lisp/startup.el: Let-bind browse-url-browser-function instead of setq-local
  2021-12-12 19:23   ` master e4e9a7c: * lisp/startup.el: Let-bind browse-url-browser-function instead of setq-local Stefan Monnier
@ 2021-12-12 19:34     ` Juri Linkov
  0 siblings, 0 replies; 2+ messages in thread
From: Juri Linkov @ 2021-12-12 19:34 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

>> -	    ,(lambda (_button) (browse-url "https://www.gnu.org/software/emacs/"))
>> +	    ,(lambda (_button)
>> +               (let ((browse-url-browser-function 'eww-browse-url))
>> +                 (browse-url "https://www.gnu.org/software/emacs/")))
>
> What's the difference between this and directly calling (eww-browse-url "...")?

I don't know if eww-browse-url can be called directly.
There is a lot of preparations in browse-url such as
ensuring `default-directory' exists and is readable, etc.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-12 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211212174920.7478.42277@vcs0.savannah.gnu.org>
     [not found] ` <20211212174921.87A7220A0A@vcs0.savannah.gnu.org>
2021-12-12 19:23   ` master e4e9a7c: * lisp/startup.el: Let-bind browse-url-browser-function instead of setq-local Stefan Monnier
2021-12-12 19:34     ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).