unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "T.V Raman" <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: describe-repeat-maps: Possible print bug:
Date: Thu, 29 Sep 2022 09:47:06 +0300	[thread overview]
Message-ID: <86o7uy4qz9.fsf@mail.linkov.net> (raw)
In-Reply-To: <25396.65413.972637.923513@google.com> (T. V. Raman's message of "Wed, 28 Sep 2022 19:14:29 -0700")

> Interesting, evaluating your test case shows the expected and desired
> output C-; 1 is shown  as the key.
>
> But sadly it doesn't work for my code.
>
> My media player module is here: (apologies in advance -- it's a large
> module, but the repeat-mode code is only a few lines.
>
> https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-m-player.el#L1442

Thanks, this reference helped to understand that
emacspeak-m-player-bind-accelerator binds only global keys,
not keys in the repeat map.  Here is a short test case
that confirms this:

  (repeat-mode 1)
  (keymap-set global-map "C-; 1" (defun test-repeat-next-line () (interactive) (next-line)))
  (defvar-keymap test-repeat-map)
  (put 'test-repeat-next-line 'repeat-map 'test-repeat-map)

And indeed 'describe-repeat-maps' outputs empty "(bound to )".
This is because the keys in the global map used to enter the
repeatable sequence currently are not handled by 'describe-repeat-maps'.
This should be fixed before the next release.

Also it was suggested to allow specifying the keys that enter
the repeatable sequence and exit it, by an additional keyword
in defvar-keymap, or by adding a new macro defvar-repeat-keymap.
This could be implemented as well.



  reply	other threads:[~2022-09-29  6:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  2:36 describe-repeat-maps: Possible print bug: T.V Raman
2022-09-28 17:55 ` Juri Linkov
2022-09-29  2:14   ` T.V Raman
2022-09-29  6:47     ` Juri Linkov [this message]
2022-09-29 14:00       ` T.V Raman
2022-11-15 18:41       ` Juri Linkov
2022-11-16 23:15         ` T.V Raman
2022-11-17  7:31           ` Juri Linkov
2022-11-17 15:19             ` T.V Raman
2022-11-17 15:35               ` T.V Raman
2022-11-17 17:55                 ` Juri Linkov
2022-11-17 18:26                   ` T.V Raman
2022-11-17 18:49                     ` Juri Linkov
2022-11-17 20:52           ` T.V Raman
2022-11-18  7:20             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86o7uy4qz9.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).