From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: describe-repeat-maps: Possible print bug: Date: Thu, 29 Sep 2022 09:47:06 +0300 Organization: LINKOV.NET Message-ID: <86o7uy4qz9.fsf@mail.linkov.net> References: <86bkqz5qp3.fsf@mail.linkov.net> <25396.65413.972637.923513@google.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="839"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 29 08:56:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odnTC-000AeD-24 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 08:56:30 +0200 Original-Received: from localhost ([::1]:56310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odnTA-0000y1-16 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 02:56:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odnQV-0007sN-N3 for emacs-devel@gnu.org; Thu, 29 Sep 2022 02:53:45 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odnQR-0000kB-En for emacs-devel@gnu.org; Thu, 29 Sep 2022 02:53:41 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7021220007; Thu, 29 Sep 2022 06:53:33 +0000 (UTC) In-Reply-To: <25396.65413.972637.923513@google.com> (T. V. Raman's message of "Wed, 28 Sep 2022 19:14:29 -0700") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296449 Archived-At: > Interesting, evaluating your test case shows the expected and desired > output C-; 1 is shown as the key. > > But sadly it doesn't work for my code. > > My media player module is here: (apologies in advance -- it's a large > module, but the repeat-mode code is only a few lines. > > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-m-player.el#L1442 Thanks, this reference helped to understand that emacspeak-m-player-bind-accelerator binds only global keys, not keys in the repeat map. Here is a short test case that confirms this: (repeat-mode 1) (keymap-set global-map "C-; 1" (defun test-repeat-next-line () (interactive) (next-line))) (defvar-keymap test-repeat-map) (put 'test-repeat-next-line 'repeat-map 'test-repeat-map) And indeed 'describe-repeat-maps' outputs empty "(bound to )". This is because the keys in the global map used to enter the repeatable sequence currently are not handled by 'describe-repeat-maps'. This should be fixed before the next release. Also it was suggested to allow specifying the keys that enter the repeatable sequence and exit it, by an additional keyword in defvar-keymap, or by adding a new macro defvar-repeat-keymap. This could be implemented as well.