From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: theo@thornhill.no, emacs-devel@gnu.org
Subject: Re: master 08c80c45dde: Don't use file-truepath in Eglot (bug#70036)
Date: Thu, 18 Apr 2024 08:49:19 +0300 [thread overview]
Message-ID: <86o7a7fcf4.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm52b9ipvv-CB-g5Ga71b3ubQf7jAGiLc505yAJYn7mTnKg@mail.gmail.com> (message from João Távora on Thu, 18 Apr 2024 01:24:59 +0100)
> From: João Távora <joaotavora@gmail.com>
> Date: Thu, 18 Apr 2024 01:24:59 +0100
> Cc: emacs-devel@gnu.org
>
> Let's say that during the Eglot session I visit both main.cpp
> and mainlink.cpp in different buffers (either because I don't visit
> them at the same time or because find-file-existing-other-name is
> nil). Then I press M-? on lib.h's foo() to tell me who references it.
>
> Before you change, Eglot will -- correctly -- tell me there is a single
> user of lib.h's foo() function in my project.
>
> After your change, it tells me there are two users. This is wrong,
> there is only one.
>
> It could be that some servers with direct access to the file system
> can deduplicate the information and add back the symlink smarts.
>
> But clangd doesn't do this, and in general servers _can't_ do
> this because LSP models a virtual file system.
>
> And for symlinks to large enough files, I'd be surprised if this
> doesn't slow down the performance of the server because it has to
> analyse what it is told is a completely new file.
>
> So this seems like a pretty big flaw to me after just minimal
> surface scratching. Please reinstate the previous code.
I asked exactly this question when the change was discussed, and was
told that symlinks are not a problem.
If we need to support symlinks in Emacs instead of leaving this to the
LSP servers, we could perhaps do that once in some strategic place,
instead of using file-truename everywhere where normally
expand-file-name would do. Or maybe explicitly test with
file-symlink-p before using file-truename, which is (and has to be)
pretty expensive. IOW, "punishing" everyone for the benefit of
relatively rare use cases is not the best optimization.
next prev parent reply other threads:[~2024-04-18 5:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171215083924.12380.5369373861551158668@vcs2.savannah.gnu.org>
[not found] ` <20240403132719.A18EFC12C28@vcs2.savannah.gnu.org>
2024-04-17 15:35 ` master 08c80c45dde: Don't use file-truepath in Eglot (bug#70036) João Távora
2024-04-17 18:41 ` Theodor Thornhill
2024-04-18 0:24 ` João Távora
2024-04-18 5:49 ` Eli Zaretskii [this message]
2024-04-18 6:16 ` Theodor Thornhill
2024-04-18 8:34 ` João Távora
2024-04-18 9:57 ` Theodor Thornhill
2024-04-18 15:00 ` João Távora
2024-04-18 15:44 ` Eli Zaretskii
2024-04-18 16:22 ` João Távora
2024-04-18 16:30 ` Theodor Thornhill
2024-04-18 17:12 ` João Távora
2024-04-18 16:35 ` Eli Zaretskii
2024-04-18 6:02 ` Theodor Thornhill
2024-04-18 14:49 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7a7fcf4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).