Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler

Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler

[Michael Albinus]

Mattias Engdegård <mattiase@acm.org> writes:

Hi Mattias,

>     ; * lisp/auth-source.el: add declarations to silence compiler
> ---
>  lisp/auth-source.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lisp/auth-source.el b/lisp/auth-source.el
> index 18670ed620b..a8bd9855720 100644
> --- a/lisp/auth-source.el
> +++ b/lisp/auth-source.el
> @@ -2546,6 +2546,9 @@ Adapt also mode line."
>    (when read-passwd-mode
>      (read-passwd-toggle-visibility)))
>  
> +(defvar overriding-text-conversion-style)
> +(declare-function set-text-conversion-style "textconv.c")
> +
>  ;;;###autoload
>  (defun read-passwd (prompt &optional confirm default)
>    "Read a password, prompting with PROMPT, and return it.

Well, I've seen these declarations in subr.el, but I didn't keep them
when moving the code to auth-source.el. After that, I made 'make
bootstrap' w/o a respective warning.

So I wonder what's the difference between your and my environment which
requires these declarations. Just being curious, nothing else :-)

Best regards, Michael.

Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler

[Mattias Engdegård]

5 apr. 2024 kl. 10.08 skrev Michael Albinus <michael.albinus@gmx.de>:

> Well, I've seen these declarations in subr.el, but I didn't keep them
> when moving the code to auth-source.el. After that, I made 'make
> bootstrap' w/o a respective warning.
> 
> So I wonder what's the difference between your and my environment which
> requires these declarations. Just being curious, nothing else :-)

Looks like textconv.c is only compiled for X11 and Android.

Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler

[Michael Albinus]

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

Hi Mattias,

>> Well, I've seen these declarations in subr.el, but I didn't keep them
>> when moving the code to auth-source.el. After that, I made 'make
>> bootstrap' w/o a respective warning.
>> 
>> So I wonder what's the difference between your and my environment which
>> requires these declarations. Just being curious, nothing else :-)
>
> Looks like textconv.c is only compiled for X11 and Android.

Thanks.

Best regards, Michael.

Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: emacs-devel <emacs-devel@gnu.org>
> Date: Fri, 05 Apr 2024 10:29:38 +0200
> 
> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
> 
> Hi Mattias,
> 
> >> Well, I've seen these declarations in subr.el, but I didn't keep them
> >> when moving the code to auth-source.el. After that, I made 'make
> >> bootstrap' w/o a respective warning.
> >> 
> >> So I wonder what's the difference between your and my environment which
> >> requires these declarations. Just being curious, nothing else :-)
> >
> > Looks like textconv.c is only compiled for X11 and Android.
> 
> Thanks.

I guess tis means those declarations need to be copied/moved to
auth-source.el, right?