From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.
Date: Fri, 15 Mar 2024 13:47:58 +0200 [thread overview]
Message-ID: <86il1n90nl.fsf@gnu.org> (raw)
In-Reply-To: <87o7bfu4u4.fsf@yahoo.com> (message from Po Lu on Fri, 15 Mar 2024 19:12:03 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 15 Mar 2024 19:12:03 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > +widgets; kill all xwidget-webkit buffers for changes in this setting
> > +to take effect. */);
>
> But this isn't true: the changes will take effect in new WebKit widgets
> whether or not some widgets already exist with a different value of this
> setting.
Feel free to rephrase, but please do NOT lose practical information,
which is important to users, and without which that part of the doc
string is basically useless. We must tell users what to do after they
change the value of the variable, for the doc string to be of any use.
(And in the future, may I suggest that you discuss your changes that
remove useful information, before going ahead and silently making
unilateral changes like this one? Not only will it be more polite, it
will also lower the probability of letting less-than-useful doc
strings slip past us into the release.)
prev parent reply other threads:[~2024-03-15 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171049137450.14047.14690023335994985946@vcs2.savannah.gnu.org>
[not found] ` <20240315082934.ED7D3C1FB4C@vcs2.savannah.gnu.org>
2024-03-15 11:12 ` master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix Po Lu
2024-03-15 11:47 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86il1n90nl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).