From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix. Date: Fri, 15 Mar 2024 13:47:58 +0200 Message-ID: <86il1n90nl.fsf@gnu.org> References: <171049137450.14047.14690023335994985946@vcs2.savannah.gnu.org> <20240315082934.ED7D3C1FB4C@vcs2.savannah.gnu.org> <87o7bfu4u4.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11132"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 15 12:48:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rl63P-0002hK-Iy for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Mar 2024 12:48:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rl62d-0005MZ-Mb; Fri, 15 Mar 2024 07:48:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl62b-0005M9-U7 for emacs-devel@gnu.org; Fri, 15 Mar 2024 07:48:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rl62b-00062a-G3; Fri, 15 Mar 2024 07:48:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5YTDUcsDvxAxrOlErL7dRXIamDEjkSGDO5CTJbgDaBY=; b=L7tGuEQu66qj KH2LYrj1HOAHyUZf91x3ezudvLmOh+qG1rDWBQNJhPiqj94ApV0XwohU+ZzChCFvrlWvZ//RsTprq gyhtA0GO8dxcXsUmkcoU4A2P7Ig4GFBRoptnMbVTSM92LNkCHLXq8E6F1vReRWwci9nNUdye2hfIr n1s8oJ4DGxhHmgDJZI0zy5kbTn/9a9c/sBaspQp9obtRK9u6H4loUGxdUcPmKD+RQNLyUds9fAO1z fANZVEN4yyLZI2qJK17RMeXjsqJOsP9Wwmm1CNqs/QIUXJmnpz1sGr/16Wsarv0iB9ypX58fWUsAK PvfW1ZnRTTCCCoRD/2VL/w==; In-Reply-To: <87o7bfu4u4.fsf@yahoo.com> (message from Po Lu on Fri, 15 Mar 2024 19:12:03 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317058 Archived-At: > From: Po Lu > Cc: Eli Zaretskii > Date: Fri, 15 Mar 2024 19:12:03 +0800 > > Eli Zaretskii writes: > > > +widgets; kill all xwidget-webkit buffers for changes in this setting > > +to take effect. */); > > But this isn't true: the changes will take effect in new WebKit widgets > whether or not some widgets already exist with a different value of this > setting. Feel free to rephrase, but please do NOT lose practical information, which is important to users, and without which that part of the doc string is basically useless. We must tell users what to do after they change the value of the variable, for the doc string to be of any use. (And in the future, may I suggest that you discuss your changes that remove useful information, before going ahead and silently making unilateral changes like this one? Not only will it be more polite, it will also lower the probability of letting less-than-useful doc strings slip past us into the release.)