From: Eli Zaretskii <eliz@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master 8bee4060ea4 2/2: Add peg.el as a built-in library
Date: Tue, 16 Apr 2024 15:31:06 +0300 [thread overview]
Message-ID: <86cyqpjxpx.fsf@gnu.org> (raw)
In-Reply-To: <87pluq6llr.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Mon, 15 Apr 2024 20:18:56 -0700)
> From: Eric Abrahamsen <eric@ericabrahamsen.net>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
> Date: Mon, 15 Apr 2024 20:18:56 -0700
>
>
> On 04/14/24 07:58 AM, Eli Zaretskii wrote:
> >> From: Stefan Monnier <monnier@iro.umontreal.ca>
> >> Cc: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-devel@gnu.org
> >> Date: Sat, 13 Apr 2024 15:36:14 -0400
> >>
> >> > Ping! Eric, any progress with this?
> >>
> >> I fixed the test failures.
> >
> > Thanks.
> >
> > Eric, this leaves the documentation-related comments in my message
> > from 2 weeks ago; could you please take care of those?
>
> Done! Thank you for the push, and thanks to Stefan for fixing the tests.
>
> I hope the docs read a bit better now -- I've also removed the mention
> that `peg-parse' could also accept a single list of PEXS, as I don't
> think it can any more (and I don't think it needs to be *so* flexible as
> all that).
Thanks, but it looks like you made some editing mistake, which deleted
too much of the text, so the commit was reverted. Please take a look
and fix as needed; I tried to figure out what you wanted to do, but
couldn't, presumably because too much of the text was inadvertently
lost when you installed the changes.
prev parent reply other threads:[~2024-04-16 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 7:33 master 8bee4060ea4 2/2: Add peg.el as a built-in library Eli Zaretskii
2024-04-01 14:28 ` Eric Abrahamsen
2024-04-03 3:03 ` Eric Abrahamsen
2024-04-13 8:04 ` Eli Zaretskii
2024-04-13 18:00 ` Stefan Monnier
2024-04-13 18:13 ` Eli Zaretskii
2024-04-13 19:36 ` Stefan Monnier
2024-04-14 4:58 ` Eli Zaretskii
2024-04-16 3:18 ` Eric Abrahamsen
2024-04-16 12:31 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyqpjxpx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).