From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 8bee4060ea4 2/2: Add peg.el as a built-in library Date: Tue, 16 Apr 2024 15:31:06 +0300 Message-ID: <86cyqpjxpx.fsf@gnu.org> References: <86plvac0u0.fsf@gnu.org> <8734s55f98.fsf@ericabrahamsen.net> <87le5v407q.fsf@ericabrahamsen.net> <868r1hr8mq.fsf@gnu.org> <86jzl0o80h.fsf@gnu.org> <87pluq6llr.fsf@ericabrahamsen.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36152"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 16 14:32:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwhyi-00099F-AA for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Apr 2024 14:32:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwhy3-0008Au-6z; Tue, 16 Apr 2024 08:31:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwhxv-00086h-OT for emacs-devel@gnu.org; Tue, 16 Apr 2024 08:31:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwhxu-0001Yi-CU; Tue, 16 Apr 2024 08:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7sRCGdBUhylMVOIPn5koLDitdpsKiQmuPD4fjtSGvG8=; b=aYhvOUdzKPmw uayDbP0q/X7gKDQp55D8beAUALwAQcEyBe6Lx8rSFsuD5FFt3E/qS2AYcK+i5LdKf0cbhqg8tFmbp aXpHpD/ylez5wvrnDkHRx27xiE9fiaalp8LIdFWk1kuMDg8m4icOetZtZl6uyeiJmSTuI0klfoWlE UFDhGkA4Q9tkHocJChr/rlvAfzJSGKrTW2vTuLdT4q8kuHbcVj4Zn2AaBDwBrhU0xCrEyefBMEPXC +mH5O8XcDOsYGkwiTCBc3P7jxDCUZRywu4JzIb9/hbY7+8fMxCZCGiwEaxF5Uc5cLCk7Uo4GBsEbH 2yAu+goHxp2fgs/uHGKu9g==; In-Reply-To: <87pluq6llr.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Mon, 15 Apr 2024 20:18:56 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317750 Archived-At: > From: Eric Abrahamsen > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Mon, 15 Apr 2024 20:18:56 -0700 > > > On 04/14/24 07:58 AM, Eli Zaretskii wrote: > >> From: Stefan Monnier > >> Cc: Eric Abrahamsen , emacs-devel@gnu.org > >> Date: Sat, 13 Apr 2024 15:36:14 -0400 > >> > >> > Ping! Eric, any progress with this? > >> > >> I fixed the test failures. > > > > Thanks. > > > > Eric, this leaves the documentation-related comments in my message > > from 2 weeks ago; could you please take care of those? > > Done! Thank you for the push, and thanks to Stefan for fixing the tests. > > I hope the docs read a bit better now -- I've also removed the mention > that `peg-parse' could also accept a single list of PEXS, as I don't > think it can any more (and I don't think it needs to be *so* flexible as > all that). Thanks, but it looks like you made some editing mistake, which deleted too much of the text, so the commit was reverted. Please take a look and fix as needed; I tried to figure out what you wanted to do, but couldn't, presumably because too much of the text was inadvertently lost when you installed the changes.