unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Do not install ChangeLog.1 in man1dir
@ 2015-04-12 15:28 Ashish SHUKLA
  2015-04-12 18:30 ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Ashish SHUKLA @ 2015-04-12 15:28 UTC (permalink / raw)
  To: emacs-devel


[-- Attachment #1.1: Type: text/plain, Size: 364 bytes --]

Hi

Since ChangeLog files are renamed in dd1404cca, 'make install' installs
ChangeLog.1 in man1dir.

The attached diff fixes it.

Thanks!
-- 
Ashish SHUKLA

“An hour sitting with a pretty girl on a park bench passes like a minute, but a
minute sitting on a hot stove seems like an hour. That's relativity” (Albert
Einstein)

Sent from my Emacs

[-- Attachment #1.2: 0001-Do-not-install-ChangeLog.1-in-man1dir.patch --]
[-- Type: text/plain, Size: 1048 bytes --]

From 40318b2d142d2a4cd6d1d573f36fc999e0ce422f Mon Sep 17 00:00:00 2001
From: Ashish SHUKLA <ashish.is@lostca.se>
Date: Sun, 12 Apr 2015 20:44:38 +0530
Subject: [PATCH] Do not install ChangeLog.1 in man1dir

---
 Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.in b/Makefile.in
index 9f235d5..381b32a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -684,12 +684,13 @@ install-man:
 	thisdir=`/bin/pwd`; \
 	cd ${mansrcdir}; \
 	for page in *.1; do \
+	  if [ "$${page}" != ChangeLog.1 ]; then \
 	  dest=`echo "$${page}" | sed -e 's/\.1$$//' -e '$(TRANSFORM)'`.1; \
 	  (cd "$${thisdir}"; \
 	   ${INSTALL_DATA} ${mansrcdir}/$${page} "$(DESTDIR)${man1dir}/$${dest}"); \
 	  [ -n "${GZIP_PROG}" ] || continue ; \
 	  rm -f "$(DESTDIR)${man1dir}/$${dest}.gz"; \
-	  ${GZIP_PROG} -9n "$(DESTDIR)${man1dir}/$${dest}" || true; \
+	  ${GZIP_PROG} -9n "$(DESTDIR)${man1dir}/$${dest}" || true; fi; \
 	done
 
 ## Install those items from etc/ that need to end up elsewhere.
-- 
2.2.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Do not install ChangeLog.1 in man1dir
  2015-04-12 15:28 [PATCH] Do not install ChangeLog.1 in man1dir Ashish SHUKLA
@ 2015-04-12 18:30 ` Paul Eggert
  2015-04-12 19:31   ` Ashish SHUKLA
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2015-04-12 18:30 UTC (permalink / raw)
  To: Ashish SHUKLA, emacs-devel

Thanks for reporting the problem.  I fixed it in a simpler way, by renaming 
ChangeLog.1 to ChangeLog.01 (a naming convention already used in lisp/erc) so 
that 'make install' doesn't think it's a man page.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Do not install ChangeLog.1 in man1dir
  2015-04-12 18:30 ` Paul Eggert
@ 2015-04-12 19:31   ` Ashish SHUKLA
  0 siblings, 0 replies; 3+ messages in thread
From: Ashish SHUKLA @ 2015-04-12 19:31 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Sun, 12 Apr 2015 11:30:00 -0700, Paul Eggert <eggert@cs.ucla.edu> said:
| Thanks for reporting the problem.  I fixed it in a simpler way, by
| renaming ChangeLog.1 to ChangeLog.01 (a naming convention already used
| in lisp/erc) so that 'make install' doesn't think it's a man page.

Great, thanks!

-- 
Ashish SHUKLA

“There are two ways of constructing a software design: One way is to make it so
simple that there are obviously no deficiencies, and the other way is to make it
so complicated that there are no obvious deficiencies.” (C. A. R. Hoare)

Sent from my Emacs

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-12 19:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-12 15:28 [PATCH] Do not install ChangeLog.1 in man1dir Ashish SHUKLA
2015-04-12 18:30 ` Paul Eggert
2015-04-12 19:31   ` Ashish SHUKLA

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).