* lexical-binding change in find-file.el breaks emacs ada-mode tests
@ 2021-05-21 18:25 Stephen Leake
0 siblings, 0 replies; only message in thread
From: Stephen Leake @ 2021-05-21 18:25 UTC (permalink / raw)
To: emacs-devel
See bug 48535.
This breaks emacs ada-mode automated tests, which rely on evaluating
elisp forms in Ada comments.
git bisect says this commit is to blame:
commit: c105017c44d4a679f7af739b2c0390b2c7850569
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue Apr 6 17:06:07 2021 -0400
* lisp/find-file.el: Make the commands oblivious to mouse/non-mouse
(ff-find-other-file): Add `event` argument.
(ff-find-other-file-other-window): Rename from
`ff-mouse-find-other-file-other-window` and use this new argument.
(ff-mouse-find-other-file, ff-mouse-find-other-file-other-window):
Make them obsolete aliases.
(ff-upcase-p): Remove unused `start` and `end` arguments and
simplify accordingly.
I looked thru the diff, but I didn't see anything obvious, so I'm
blaming the lexical-binding change. But I don't know how to fix it.
--
-- Stephe
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-21 18:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 18:25 lexical-binding change in find-file.el breaks emacs ada-mode tests Stephen Leake
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).