From: Stephen Leake <stephen_leake@member.fsf.org>
To: emacs-devel@gnu.org
Subject: Re: [RFC] etags ada parser: doesn't stop when giving broken input
Date: Tue, 09 Apr 2013 05:00:58 -0400 [thread overview]
Message-ID: <85zjx8dqnp.fsf@member.fsf.org> (raw)
In-Reply-To: <20130408.171844.1201396057660785985.yamato@redhat.com> (Masatake YAMATO's message of "Mon, 08 Apr 2013 17:18:44 +0900 (JST)")
Masatake YAMATO <yamato@redhat.com> writes:
> I expect etags stops even if broken input is given.
That's certainly reasonable
> I wrote a small patch. However, I'm not sure this is correct fix.
> Someone who knows both ada and etags, could you review this patch?
I know Ada, but not etags.
Your fix is not particular to Ada; it makes sense for any "token". It
looks reasonable to me, but I did not read the entire function (only the
patch).
Is there a test suite for etags.c? I could contribute some Ada code, if
needed.
--
-- Stephe
next prev parent reply other threads:[~2013-04-09 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 8:18 [RFC] etags ada parser: doesn't stop when giving broken input Masatake YAMATO
2013-04-09 9:00 ` Stephen Leake [this message]
2013-04-09 21:05 ` Francesco Potortì
2013-04-10 0:36 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85zjx8dqnp.fsf@member.fsf.org \
--to=stephen_leake@member.fsf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).