From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [RFC] etags ada parser: doesn't stop when giving broken input Date: Tue, 09 Apr 2013 05:00:58 -0400 Message-ID: <85zjx8dqnp.fsf@member.fsf.org> References: <20130408.171844.1201396057660785985.yamato@redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365498103 11679 80.91.229.3 (9 Apr 2013 09:01:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Apr 2013 09:01:43 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 11:01:47 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UPUQy-0004WY-M0 for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2013 11:01:44 +0200 Original-Received: from localhost ([::1]:57498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPUQy-0000WC-Bs for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2013 05:01:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPUQr-0000P1-Gw for emacs-devel@gnu.org; Tue, 09 Apr 2013 05:01:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPUQm-0004e5-Km for emacs-devel@gnu.org; Tue, 09 Apr 2013 05:01:37 -0400 Original-Received: from vms173013pub.verizon.net ([206.46.173.13]:63232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPUQm-0004e0-GO for emacs-devel@gnu.org; Tue, 09 Apr 2013 05:01:32 -0400 Original-Received: from TAKVER ([unknown] [72.66.125.164]) by vms173013.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MKZ00BDFD1PGH50@vms173013.mailsrvcs.net> for emacs-devel@gnu.org; Tue, 09 Apr 2013 04:01:16 -0500 (CDT) In-reply-to: <20130408.171844.1201396057660785985.yamato@redhat.com> (Masatake YAMATO's message of "Mon, 08 Apr 2013 17:18:44 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (windows-nt) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.46.173.13 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158796 Archived-At: Masatake YAMATO writes: > I expect etags stops even if broken input is given. That's certainly reasonable > I wrote a small patch. However, I'm not sure this is correct fix. > Someone who knows both ada and etags, could you review this patch? I know Ada, but not etags. Your fix is not particular to Ada; it makes sense for any "token". It looks reasonable to me, but I did not read the entire function (only the patch). Is there a test suite for etags.c? I could contribute some Ada code, if needed. -- -- Stephe