From: kai.grossjohann@gmx.net (Kai Großjohann)
Subject: Re: 4 minor suggestions for files.el
Date: Tue, 15 Apr 2003 21:14:15 +0200 [thread overview]
Message-ID: <841y03shdk.fsf@lucy.is.informatik.uni-duisburg.de> (raw)
In-Reply-To: 200304142022.h3EKMHRu026814@rum.cs.yale.edu
I somehow don't really feel qualified to comment, but I'll try my
best, anyway.
"Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu> writes:
> 1 - Don't allow viewing non-existent files. The interactive spec already
> ensures that's the case, but it doesn't work when the function
> is called from dired or somesuch (the file might have existed
> when the dired buffer was created).
Nice.
> 2 - Prompt the user when trying to open a very large file. My Emacs crawls
> to a near halt when I try to open a 16MB file, so if I ever try to
> open such a file, I'd rather be warned.
Maybe add a group and a type to the defcustom.
Otherwise, me likee.
> 3 - Don't catch errors to turn them into messages when debug-on-error
> is set to t. I wish I could solve it more generically.
I wonder what happens with debug-on-signal? If that catches the
errors, then maybe your change isn't necessary.
If that does not catch the errors, you might extend your code to
check debug-on-signal, as well.
As a different approach, maybe it is useful to somehow make
condition-case easier to debug? For example, one could design a
"debugging mode" which turns on debug-on-error, perhaps
debug-on-signal, and also does something special so that
condition-case invokes the debugger in case an error happened.
> 4 - Don't ask for confirmation when the user has just gone through the
> trouble of typing the whole M-x revert-buffer RET thing.
Good idea, but will it work if the user binds it to C-c RET, say? (I
know, that's not allowed, but perhaps they chose C-c f RET.)
> 5 - Don't junk the buffer-undo-list when reverting while preserving modes.
> This is convenient with things like auto-revert or VC, especially
> combined with the undo-in-region feature. It does require changes
> in the C code for insert-file-contents as well, since it
> currently always junks the undo list. These changes aren't
> included here, but they are not needed for the code to work
> as well as before.
Nice.
--
file-error; Data: (Opening input file no such file or directory ~/.signature)
next prev parent reply other threads:[~2003-04-15 19:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 20:22 4 minor suggestions for files.el Stefan Monnier
2003-04-15 19:14 ` Kai Großjohann [this message]
2003-04-15 20:16 ` Kevin Rodgers
2003-04-16 4:40 ` Richard Stallman
2003-04-17 21:39 ` Stefan Monnier
2003-04-18 11:28 ` Richard Stallman
2003-04-18 13:24 ` Andre Spiegel
2003-04-18 14:23 ` Stefan Monnier
2003-04-18 14:36 ` Andre Spiegel
2003-04-18 14:40 ` Stefan Monnier
2003-04-19 19:11 ` Stefan Monnier
2003-04-22 0:45 ` Richard Stallman
2003-04-19 13:35 ` Richard Stallman
2003-04-29 21:07 ` Stefan Monnier
2003-05-05 14:32 ` Richard Stallman
2003-05-05 14:52 ` Andre Spiegel
2003-05-06 10:14 ` Richard Stallman
2003-05-06 10:56 ` Andre Spiegel
2003-05-07 11:51 ` Richard Stallman
2003-05-07 12:31 ` Andre Spiegel
2003-05-07 14:26 ` Stefan Monnier
2003-05-09 11:20 ` Richard Stallman
2003-05-06 13:00 ` Stefan Monnier
2003-05-07 11:50 ` Richard Stallman
2003-05-05 14:57 ` Stefan Monnier
2003-05-06 10:14 ` Richard Stallman
2003-05-06 12:54 ` Stefan Monnier
2003-05-07 11:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841y03shdk.fsf@lucy.is.informatik.uni-duisburg.de \
--to=kai.grossjohann@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).