From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: 4 minor suggestions for files.el
Date: Tue, 29 Apr 2003 17:07:20 -0400 [thread overview]
Message-ID: <200304292107.h3TL7Kl9007427@rum.cs.yale.edu> (raw)
In-Reply-To: E196sVL-0004qa-00@fencepost.gnu.org
> VC does a revert-buffer after each version control operation, so that
> changes in version headers are picked up.
>
> If I understand correctly, the revert-buffer would be undoable.
>
> I think that is what he is proposing.
>
> I think that is a misguided feature. It is not right to undo
> the revert-buffer unless you can undo the whole VC operation with it.
Why? Especially with `undo-in-region' it doesn't make sense to
undo the operation when only part of the revert is undone (or
as is more often the case for me: when only changes prior to the
revert are undone).
> But that, if we can implement it, must be a VC operation;
> M-x undo should not be able to do it.
I don't see why not. Just like we can undo changes that were
saved with C-x C-s, it makes perfect sense to undo changes
that were made by a "minor" revert-buffer (my patch defines
"minor" as "which preserves minor-modes").
> I think that the correct way for check-in and update to interact with
> M-x undo is to transpose the old undo list somehow to the buffer as it
> has been updated.
That's what undo-in-region does.
> If I edit the buffer and then do an RCS check-in, and the check-in
> updates an RCS header in the file, and then I undo, this should not
> undo the change in the RCS header. Rather, it should undo the change
> that I made manually before the check-in.
Just because there's one case where care might be needed, we shouldn't
prevent people for whom this doesn't apply to benefit from more
flexibility.
> Likewise, if I edit the buffer and then do a CVS update, I should
> then be able to undo the edit I made, but not the changes made by
> the CVS update.
Why not ?
Stefan
next prev parent reply other threads:[~2003-04-29 21:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 20:22 4 minor suggestions for files.el Stefan Monnier
2003-04-15 19:14 ` Kai Großjohann
2003-04-15 20:16 ` Kevin Rodgers
2003-04-16 4:40 ` Richard Stallman
2003-04-17 21:39 ` Stefan Monnier
2003-04-18 11:28 ` Richard Stallman
2003-04-18 13:24 ` Andre Spiegel
2003-04-18 14:23 ` Stefan Monnier
2003-04-18 14:36 ` Andre Spiegel
2003-04-18 14:40 ` Stefan Monnier
2003-04-19 19:11 ` Stefan Monnier
2003-04-22 0:45 ` Richard Stallman
2003-04-19 13:35 ` Richard Stallman
2003-04-29 21:07 ` Stefan Monnier [this message]
2003-05-05 14:32 ` Richard Stallman
2003-05-05 14:52 ` Andre Spiegel
2003-05-06 10:14 ` Richard Stallman
2003-05-06 10:56 ` Andre Spiegel
2003-05-07 11:51 ` Richard Stallman
2003-05-07 12:31 ` Andre Spiegel
2003-05-07 14:26 ` Stefan Monnier
2003-05-09 11:20 ` Richard Stallman
2003-05-06 13:00 ` Stefan Monnier
2003-05-07 11:50 ` Richard Stallman
2003-05-05 14:57 ` Stefan Monnier
2003-05-06 10:14 ` Richard Stallman
2003-05-06 12:54 ` Stefan Monnier
2003-05-07 11:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304292107.h3TL7Kl9007427@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).