[PATCH] comment unused args in resize_cb() in src/widget.c

[PATCH] comment unused args in resize_cb() in src/widget.c

[Adam Kandur via Emacs development discussions.]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hi emacs!
I've been playing with emacs sources and noticed resize_cb () in src/widget.c accept 4 arguments but use only one inside. I'm new in programming (and C), but i decided to comment other args and build it.
Maybe it would be usefull.Adam.

[-- Attachment #2: 0001-comment-unused-args-in-resize_cb-in-src-widget.c.patch --]
[-- Type: text/x-patch, Size: 848 bytes --]

From 8d7edc5bc1fa6078af0e8588fc37bad6e5602a1e Mon Sep 17 00:00:00 2001
From: Adam Kandur <rndd@tuta.io>
Date: Tue, 7 Sep 2021 20:20:00 +0300
Subject: [PATCH] comment unused args in resize_cb() in src/widget.c

---
 src/widget.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/widget.c b/src/widget.c
index dd43fd1c46..6ee0a5c135 100644
--- a/src/widget.c
+++ b/src/widget.c
@@ -354,10 +354,10 @@ EmacsFrameInitialize (Widget request, Widget new, ArgList dum1, Cardinal *dum2)
 }
 
 static void
-resize_cb (Widget widget,
-           XtPointer closure,
-           XEvent *event,
-           Boolean *continue_to_dispatch)
+resize_cb (Widget widget)
+           /* XtPointer closure, */
+           /* XEvent *event, */
+           /* Boolean *continue_to_dispatch) */
 {
   EmacsFrameResize (widget);
 }
-- 
2.32.0

Re: [PATCH] comment unused args in resize_cb() in src/widget.c

[Eli Zaretskii]

> Date: Tue, 7 Sep 2021 19:26:50 +0200 (CEST)
> From:  Adam Kandur via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> I've been playing with emacs sources and noticed resize_cb () in src/widget.c accept 4 arguments but use only one inside. I'm new in programming (and C), but i decided to comment other args and build it.

It's used as a callback, so it has to have the signature expected by
XtAddRawEventHandler.  Even if it doesn't use some of the arguments.

Thanks.