unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: emacs-devel@gnu.org
Subject: Re: Drawing dirty rectangles with expose_window:  row->clip = fr
Date: Tue, 02 Apr 2019 17:48:11 +0300	[thread overview]
Message-ID: <83wokcfopg.fsf@gnu.org> (raw)
In-Reply-To: <m2h8bhqifx.wl%esq@lawlist.com> (message from Keith David Bershatsky on Mon, 01 Apr 2019 18:55:46 -0700)

> Date: Mon, 01 Apr 2019 18:55:46 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
> 
> Even though ns_clip_to_rect returns TRUE, "row->clip = fr;" in expose_window can sometimes prevent glyphs from being drawn within the rectangle that is passed as an argument of ns_clip_to_rect.  This has the effect of permitting fake cursors to be drawn, but then glyphs cannot be drawn on top of hollow/box fake cursors.
> 
> How can I reconcile a false_positive with ns_clip_to_rect?

Is the fake cursor entirely inside the rectangle described by 'fr', or
is it or some of its parts outside?

> Or, perhaps "row->clip = fr;" in expose_window needs to be adjusted to permit the drawing of glyphs?

It already is, AFAIU.  Barring bugs, that is.



  reply	other threads:[~2019-04-02 14:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  1:55 Drawing dirty rectangles with expose_window: row->clip = fr Keith David Bershatsky
2019-04-02 14:48 ` Eli Zaretskii [this message]
2019-04-02 19:34 ` Alan Third
  -- strict thread matches above, loose matches on Subject: below --
2019-04-02 16:27 Keith David Bershatsky
2019-04-02 16:51 ` Eli Zaretskii
2019-04-02 17:42 Keith David Bershatsky
2019-04-02 20:42 Keith David Bershatsky
2019-04-03 19:28 Keith David Bershatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wokcfopg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).