From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Drawing dirty rectangles with expose_window:  row->clip = fr
Date: Tue, 02 Apr 2019 17:48:11 +0300
Message-ID: <83wokcfopg.fsf@gnu.org>
References: <m2h8bhqifx.wl%esq@lawlist.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="246948"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Keith David Bershatsky <esq@lawlist.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 16:50:34 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hBKkE-00129s-8t
	for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 16:50:34 +0200
Original-Received: from localhost ([127.0.0.1]:52068 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hBKkD-00074O-5e
	for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 10:50:33 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:36747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hBKhi-0006Fl-JT
	for emacs-devel@gnu.org; Tue, 02 Apr 2019 10:47:59 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40484)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hBKhi-0003dk-An; Tue, 02 Apr 2019 10:47:58 -0400
Original-Received: from [176.228.60.248] (port=4512 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hBKhh-0000qz-O1; Tue, 02 Apr 2019 10:47:58 -0400
In-reply-to: <m2h8bhqifx.wl%esq@lawlist.com> (message from Keith David
	Bershatsky on Mon, 01 Apr 2019 18:55:46 -0700)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:234869
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/234869>

> Date: Mon, 01 Apr 2019 18:55:46 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
> 
> Even though ns_clip_to_rect returns TRUE, "row->clip = fr;" in expose_window can sometimes prevent glyphs from being drawn within the rectangle that is passed as an argument of ns_clip_to_rect.  This has the effect of permitting fake cursors to be drawn, but then glyphs cannot be drawn on top of hollow/box fake cursors.
> 
> How can I reconcile a false_positive with ns_clip_to_rect?

Is the fake cursor entirely inside the rectangle described by 'fr', or
is it or some of its parts outside?

> Or, perhaps "row->clip = fr;" in expose_window needs to be adjusted to permit the drawing of glyphs?

It already is, AFAIU.  Barring bugs, that is.