unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master bec5cfe: Improve integer range checking
       [not found] ` <20200405082444.4341E20BC2@vcs0.savannah.gnu.org>
@ 2020-04-05 16:35   ` Glenn Morris
  2020-04-05 16:52     ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Glenn Morris @ 2020-04-05 16:35 UTC (permalink / raw)
  To: emacs-devel; +Cc: Paul Eggert


> branch: master
> commit bec5cfee7660f6e283efbd30a693a6f8e9ea46b8

Hi,
This fails to build for me with --enable-check-lisp-object-type and gcc 8.3.1:

bignum.c: In function 'check_int_nonnegative':
bignum.c:468:23: error: used struct type value where scalar is required
   return Fnatnump (x) ? check_integer_range (x, 0, INT_MAX) : 0;
                       ^
bignum.c:469:1: warning: control reaches end of non-void function



^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: master bec5cfe: Improve integer range checking
  2020-04-05 16:35   ` master bec5cfe: Improve integer range checking Glenn Morris
@ 2020-04-05 16:52     ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2020-04-05 16:52 UTC (permalink / raw)
  To: Glenn Morris; +Cc: eggert, emacs-devel

> From: Glenn Morris <rgm@gnu.org>
> Date: Sun, 05 Apr 2020 12:35:22 -0400
> Cc: Paul Eggert <eggert@cs.ucla.edu>
> 
> bignum.c: In function 'check_int_nonnegative':
> bignum.c:468:23: error: used struct type value where scalar is required
>    return Fnatnump (x) ? check_integer_range (x, 0, INT_MAX) : 0;
>                        ^
> bignum.c:469:1: warning: control reaches end of non-void function

Thanks, I hope I fixed this.



^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-05 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200405082442.20051.45988@vcs0.savannah.gnu.org>
     [not found] ` <20200405082444.4341E20BC2@vcs0.savannah.gnu.org>
2020-04-05 16:35   ` master bec5cfe: Improve integer range checking Glenn Morris
2020-04-05 16:52     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).