From: Eli Zaretskii <eliz@gnu.org>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: andrewjmoreton@gmail.com, Mark.Barton@disney.com,
emacs-devel@gnu.org, schwab@linux-m68k.org,
monnier@iro.umontreal.ca, 49822@debbugs.gnu.org,
michael.albinus@gmx.de, larsi@gnus.org
Subject: bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files
Date: Tue, 07 Sep 2021 21:19:02 +0300 [thread overview]
Message-ID: <83wnnsnt9l.fsf@gnu.org> (raw)
In-Reply-To: <87sfygl11x.fsf@gmail.com> (message from Augusto Stoffel on Tue, 07 Sep 2021 19:59:06 +0200)
> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: Mark.Barton@disney.com, andrewjmoreton@gmail.com, emacs-devel@gnu.org,
> schwab@linux-m68k.org, monnier@iro.umontreal.ca, 49822@debbugs.gnu.org,
> michael.albinus@gmx.de, larsi@gnus.org
> Date: Tue, 07 Sep 2021 19:59:06 +0200
>
> On Tue, 7 Sep 2021 at 20:48, Eli Zaretskii <eliz@gnu.org> wrote:
>
> >> From: Augusto Stoffel <arstoffel@gmail.com>
> >> Date: Tue, 07 Sep 2021 19:37:41 +0200
> >> Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org,
> >> Andreas Schwab <schwab@linux-m68k.org>,
> >> Stefan Monnier <monnier@iro.umontreal.ca>, 49822@debbugs.gnu.org,
> >> Michael Albinus <michael.albinus@gmx.de>, Lars Ingebrigtsen <larsi@gnus.org>
> >>
> >> Okay then. Since there seem to be no better alternatives, I have
> >> attached a new patch reducing the limit to a hard-coded 1024 bytes. If
> >> some day someone adds a variable specifying a more precise limit, then
> >> we can change this.
> >
> > I thought the conclusion was that we do know the limits, but they are
> > different on different OSes? If so, why not use the correct limit for
> > each OS, instead of using the most strict limit? The underlying OS is
> > available in system-type.
> >
> >> - (if (<= (string-bytes code) 4096)
> >> + (if (<= (string-bytes code) 1024)
> >
> > In any case, IMO this should be a defconst with a suitable doc string,
> > so that we'd have this stuff documented for posterity.
> >
> > Thanks.
>
> Yes, I agree this should be a defconst, defined in comint.el or maybe
> even in C, if there turns out to be a sensible way to query the OS.
>
> I'm afraid I've already proved that I am not up to this particular task :-)
I didn't mean to say anything like that, not at all. Mine was a minor
comment, it's supposed to be easy to augment your patch to avoid those
minor issues. Nothing complicated or fancy is expected, just a
defconst with a value conditioned on system-type.
As for where should that defconst live, I personally have no problem
with its living in python.el for now. We can always move it later if
the need arises.
Thanks.
next prev parent reply other threads:[~2021-09-07 18:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210903122828.16890.65271@vcs0.savannah.gnu.org>
[not found] ` <20210903122829.EAAC220B71@vcs0.savannah.gnu.org>
2021-09-03 23:04 ` master e32c7d2: Change Python eval to send directly instead of using temporary files Stefan Monnier
2021-09-04 9:49 ` bug#49822: " Augusto Stoffel
2021-09-04 13:52 ` Stefan Monnier
2021-09-05 6:13 ` Barton, Mark
2021-09-05 7:46 ` bug#49822: " Augusto Stoffel
2021-09-05 8:10 ` Augusto Stoffel
2021-09-05 17:18 ` bug#49822: " Mark Barton
2021-09-05 17:33 ` Mark Barton
2021-09-05 17:46 ` Augusto Stoffel
2021-09-05 7:41 ` bug#49822: " Lars Ingebrigtsen
2021-09-05 16:36 ` Andreas Schwab
2021-09-05 18:40 ` Augusto Stoffel
2021-09-06 7:43 ` Michael Albinus
2021-09-06 8:40 ` Andreas Schwab
2021-09-06 11:23 ` Michael Albinus
2021-09-06 11:53 ` Andreas Schwab
2021-09-06 12:00 ` Michael Albinus
2021-09-06 16:08 ` Augusto Stoffel
[not found] ` <855f9eaf1b1d39bb9325d0a88e7f66c0ba0b45d0.camel@gmail.com>
2021-09-06 22:15 ` Andy Moreton
2021-09-07 7:18 ` Andreas Schwab
2021-09-07 17:37 ` Augusto Stoffel
2021-09-07 17:48 ` Eli Zaretskii
2021-09-07 17:59 ` Augusto Stoffel
2021-09-07 18:19 ` Eli Zaretskii [this message]
2021-09-07 18:13 ` Augusto Stoffel
2021-09-07 18:31 ` Eli Zaretskii
2021-09-07 19:00 ` Augusto Stoffel
2021-09-07 19:16 ` Eli Zaretskii
2021-09-08 7:02 ` Michael Albinus
2021-09-08 3:17 ` Barton, Mark
2021-09-08 5:09 ` Augusto Stoffel
2021-09-08 7:50 ` Lars Ingebrigtsen
2021-09-08 14:05 ` Augusto Stoffel
2021-09-09 13:48 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnnsnt9l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49822@debbugs.gnu.org \
--cc=Mark.Barton@disney.com \
--cc=andrewjmoreton@gmail.com \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).