From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files Date: Tue, 07 Sep 2021 21:19:02 +0300 Message-ID: <83wnnsnt9l.fsf@gnu.org> References: <20210903122828.16890.65271@vcs0.savannah.gnu.org> <20210903122829.EAAC220B71@vcs0.savannah.gnu.org> <87r1e4eklw.fsf@gmail.com> <87v93fnfmm.fsf@igel.home> <87lf4aooge.fsf@gmail.com> <878s0a409g.fsf@gmx.de> <87ilzef65i.fsf@igel.home> <878s0aeyna.fsf@gmx.de> <87r1e1ex7z.fsf@igel.home> <875yvcmgm2.fsf@gmail.com> <83y288nuoq.fsf@gnu.org> <87sfygl11x.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andrewjmoreton@gmail.com, Mark.Barton@disney.com, emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@iro.umontreal.ca, 49822@debbugs.gnu.org, michael.albinus@gmx.de, larsi@gnus.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 07 20:20:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNfhr-0003HF-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 20:20:27 +0200 Original-Received: from localhost ([::1]:36350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfhq-0007nW-9a for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 14:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfhR-0007lf-Tz for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 14:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNfhR-0002E1-Md for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 14:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNfhR-0001ox-Hr for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Sep 2021 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49822 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49822-submit@debbugs.gnu.org id=B49822.16310387496929 (code B ref 49822); Tue, 07 Sep 2021 18:20:01 +0000 Original-Received: (at 49822) by debbugs.gnu.org; 7 Sep 2021 18:19:09 +0000 Original-Received: from localhost ([127.0.0.1]:57709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfgW-0001nc-9U for submit@debbugs.gnu.org; Tue, 07 Sep 2021 14:19:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfgU-0001mf-NI for 49822@debbugs.gnu.org; Tue, 07 Sep 2021 14:19:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60054) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfgO-0001Ne-Ol; Tue, 07 Sep 2021 14:18:56 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2413 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfgO-0001zA-B8; Tue, 07 Sep 2021 14:18:56 -0400 In-Reply-To: <87sfygl11x.fsf@gmail.com> (message from Augusto Stoffel on Tue, 07 Sep 2021 19:59:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213735 gmane.emacs.devel:274280 Archived-At: > From: Augusto Stoffel > Cc: Mark.Barton@disney.com, andrewjmoreton@gmail.com, emacs-devel@gnu.org, > schwab@linux-m68k.org, monnier@iro.umontreal.ca, 49822@debbugs.gnu.org, > michael.albinus@gmx.de, larsi@gnus.org > Date: Tue, 07 Sep 2021 19:59:06 +0200 > > On Tue, 7 Sep 2021 at 20:48, Eli Zaretskii wrote: > > >> From: Augusto Stoffel > >> Date: Tue, 07 Sep 2021 19:37:41 +0200 > >> Cc: Andy Moreton , emacs-devel@gnu.org, > >> Andreas Schwab , > >> Stefan Monnier , 49822@debbugs.gnu.org, > >> Michael Albinus , Lars Ingebrigtsen > >> > >> Okay then. Since there seem to be no better alternatives, I have > >> attached a new patch reducing the limit to a hard-coded 1024 bytes. If > >> some day someone adds a variable specifying a more precise limit, then > >> we can change this. > > > > I thought the conclusion was that we do know the limits, but they are > > different on different OSes? If so, why not use the correct limit for > > each OS, instead of using the most strict limit? The underlying OS is > > available in system-type. > > > >> - (if (<= (string-bytes code) 4096) > >> + (if (<= (string-bytes code) 1024) > > > > In any case, IMO this should be a defconst with a suitable doc string, > > so that we'd have this stuff documented for posterity. > > > > Thanks. > > Yes, I agree this should be a defconst, defined in comint.el or maybe > even in C, if there turns out to be a sensible way to query the OS. > > I'm afraid I've already proved that I am not up to this particular task :-) I didn't mean to say anything like that, not at all. Mine was a minor comment, it's supposed to be easy to augment your patch to avoid those minor issues. Nothing complicated or fancy is expected, just a defconst with a value conditioned on system-type. As for where should that defconst live, I personally have no problem with its living in python.el for now. We can always move it later if the need arises. Thanks.