* Re: master cff1702: Fix hanging wdired test
[not found] ` <20211115084515.88275207D5@vcs0.savannah.gnu.org>
@ 2021-11-15 11:14 ` Robert Pluim
2021-11-15 13:14 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2021-11-15 11:14 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
>>>>> On Mon, 15 Nov 2021 03:45:15 -0500 (EST), stefankangas@gmail.com (Stefan Kangas) said:
Stefan> @@ -148,11 +145,12 @@ wdired-get-filename before and after editing."
Stefan> (set-file-modes "foo" (file-modes-symbolic-to-number "+x"))
Stefan> (make-symbolic-link "foo" "bar")
Stefan> (make-directory "foodir")
Stefan> - (require 'dired-x)
Stefan> (dired-smart-shell-command "mkfifo foopipe")
Stefan> - (server-force-delete)
Stefan> - ;; FIXME? This seems a heavy-handed way of making a socket.
Stefan> - (server-start) ; Add a socket file.
Stefan> + (setq proc (make-network-process
Stefan> + :name "foo"
Stefan> + :family 'local
Stefan> + :server t
Stefan> + :service (expand-file-name "foosocket" test-dir)))
Not every platform supports local sockets, so you might want to
condition the socket on
(featurep 'make-network-process '(:family local)))
in there somewhere. (MS-Windows uses TCP sockets for `server-start',
so there will be no change on that platform anyway)
Robert
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master cff1702: Fix hanging wdired test
2021-11-15 11:14 ` master cff1702: Fix hanging wdired test Robert Pluim
@ 2021-11-15 13:14 ` Eli Zaretskii
2021-11-16 4:24 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-11-15 13:14 UTC (permalink / raw)
To: Robert Pluim; +Cc: stefan, emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 15 Nov 2021 12:14:08 +0100
> Cc: Stefan Kangas <stefan@marxist.se>
>
> >>>>> On Mon, 15 Nov 2021 03:45:15 -0500 (EST), stefankangas@gmail.com (Stefan Kangas) said:
> Stefan> @@ -148,11 +145,12 @@ wdired-get-filename before and after editing."
> Stefan> (set-file-modes "foo" (file-modes-symbolic-to-number "+x"))
> Stefan> (make-symbolic-link "foo" "bar")
> Stefan> (make-directory "foodir")
> Stefan> - (require 'dired-x)
> Stefan> (dired-smart-shell-command "mkfifo foopipe")
> Stefan> - (server-force-delete)
> Stefan> - ;; FIXME? This seems a heavy-handed way of making a socket.
> Stefan> - (server-start) ; Add a socket file.
> Stefan> + (setq proc (make-network-process
> Stefan> + :name "foo"
> Stefan> + :family 'local
> Stefan> + :server t
> Stefan> + :service (expand-file-name "foosocket" test-dir)))
>
> Not every platform supports local sockets
And what about the 'makefifo' command?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master cff1702: Fix hanging wdired test
2021-11-15 13:14 ` Eli Zaretskii
@ 2021-11-16 4:24 ` Stefan Kangas
2021-11-16 13:01 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2021-11-16 4:24 UTC (permalink / raw)
To: Eli Zaretskii, Robert Pluim; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 15 Nov 2021 12:14:08 +0100
>> Cc: Stefan Kangas <stefan@marxist.se>
>>
>> Not every platform supports local sockets, so you might want to
>> condition the socket on
>>
>> (featurep 'make-network-process '(:family local)))
Thanks! Now fixed on master (commit 1d3381ae35).
> And what about the 'makefifo' command?
I guess it has worked since the line has been added in 2019? So I
didn't change that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master cff1702: Fix hanging wdired test
2021-11-16 4:24 ` Stefan Kangas
@ 2021-11-16 13:01 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2021-11-16 13:01 UTC (permalink / raw)
To: Stefan Kangas; +Cc: rpluim, emacs-devel
> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 15 Nov 2021 20:24:00 -0800
> Cc: emacs-devel@gnu.org
>
> > And what about the 'makefifo' command?
>
> I guess it has worked since the line has been added in 2019? So I
> didn't change that.
You mean, it did NOT work, right? Not on all platforms, anyway.
There should be a skip-unless there.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-16 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211115084514.28560.821@vcs0.savannah.gnu.org>
[not found] ` <20211115084515.88275207D5@vcs0.savannah.gnu.org>
2021-11-15 11:14 ` master cff1702: Fix hanging wdired test Robert Pluim
2021-11-15 13:14 ` Eli Zaretskii
2021-11-16 4:24 ` Stefan Kangas
2021-11-16 13:01 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).