unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs 27.1 released
Date: Fri, 14 Aug 2020 09:02:36 +0300	[thread overview]
Message-ID: <83v9hllq83.fsf@gnu.org> (raw)
In-Reply-To: <7248DF65-C427-4D10-AD48-3240B3EF66A7@acm.org> (message from Mattias Engdegård on Thu, 13 Aug 2020 21:50:33 +0200)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 13 Aug 2020 21:50:33 +0200
> Cc: emacs-devel@gnu.org
> 
> 12 aug. 2020 kl. 21.21 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> > I just counted its callers, that's all.  A change in a function that
> > has many callers could have unintended consequences beyond the
> > function itself.
> 
> I'm very happy that you are taking an interest in Calc again, and especially that you took the trouble of digging into the ramifications of this little correction! I'm most curious to hear what you found out. You see, when the change to calcFunc-gcd was made, naturally I did look at its callers carefully to assess the impact. Now since you brought it up I've done so again, and found nothing new: all users of that function are either indifferent to the change, or actively benefit from it.
> 
> It seems clear that the code is less buggy now than before the change and should therefore be preferred for the sake of correctness. However, I could be wrong, and would very much benefit from your findings so that my mistakes can be fixed on master!

We are assessing this from two very different points of view: you are
thinking about fixing the bug, and I'm thinking about the dangers of
some unintended consequences of the fix destabilizing Emacs 27.2's
version of Calc.  By their very nature, unintended consequences are
unknown to you and to me, so asking for any specific details is not
useful.

(And could you please drop the thinly-veiled sarcasm, here and
elsewhere?  It makes it harder for me to discuss serious issues with
you, and I don't think I deserve the implied attitude, while doing my
job of keeping the release branch stable.)



  reply	other threads:[~2020-08-14  6:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 23:00 Emacs 27.1 released Nicolas Petton
2020-08-10 23:52 ` Stefan Kangas
2020-08-12  2:24   ` Richard Stallman
2020-08-12 14:05     ` Noam Postavsky
2020-08-24 14:25   ` Stefan Kangas
2020-08-24 14:30     ` Lars Ingebrigtsen
2020-08-24 14:56       ` Drew Adams
2020-08-11  0:50 ` Mingde (Matthew) Zeng
2020-08-11  2:59 ` 황병희
2020-08-11  4:24 ` Jay Sulzberger
2020-08-11  8:19 ` Ulrich Mueller
2020-08-11 18:25   ` Eli Zaretskii
2020-08-12  8:09     ` Michael Albinus
2020-08-12 13:48       ` Phil Sainty
2020-08-12 14:21       ` Eli Zaretskii
2020-08-12 16:20         ` Mattias Engdegård
2020-08-12 16:33           ` Robert Pluim
2020-08-12 16:47           ` Eli Zaretskii
2020-08-12 18:01             ` Mattias Engdegård
2020-08-12 18:27               ` Eli Zaretskii
2020-08-12 19:07                 ` Mattias Engdegård
2020-08-12 19:21                   ` Eli Zaretskii
2020-08-13 19:50                     ` Mattias Engdegård
2020-08-14  6:02                       ` Eli Zaretskii [this message]
2020-08-14 12:51                         ` Mattias Engdegård
2020-08-14 13:28                           ` Eli Zaretskii
2020-08-16  8:19                             ` Mattias Engdegård
2020-08-13 14:34         ` Michael Albinus
2020-08-12 12:01 ` phillip.lord
2020-08-15 17:49   ` Emacs 27.1 Windows Binaries -- testing wanted phillip.lord
2020-08-15 17:54     ` Eli Zaretskii
2020-08-15 18:38     ` Stephen Leake
2020-08-15 19:57     ` Alan Third
2020-08-17  4:44     ` Sivaram Neelakantan
2020-08-17  5:40     ` 范凯
2020-08-17 23:24     ` Emacs " Tak Kunihiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9hllq83.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).