From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 27.1 released Date: Fri, 14 Aug 2020 09:02:36 +0300 Message-ID: <83v9hllq83.fsf@gnu.org> References: <87a6z2ds3y.fsf@petton.fr> <834kp9ox92.fsf@gnu.org> <87ft8smgje.fsf@gmx.de> <83k0y4ndwz.fsf@gnu.org> <83bljfolp8.fsf@gnu.org> <01498CD4-5E25-4785-941C-D6E9A100ED7F@acm.org> <837du3oh2w.fsf@gnu.org> <83y2mjn00q.fsf@gnu.org> <7248DF65-C427-4D10-AD48-3240B3EF66A7@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 14 08:03:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6So5-0009my-Ac for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Aug 2020 08:03:13 +0200 Original-Received: from localhost ([::1]:46972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6So4-00066n-CG for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Aug 2020 02:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6Sna-0005g0-PJ for emacs-devel@gnu.org; Fri, 14 Aug 2020 02:02:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40428) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Sna-0005en-FH; Fri, 14 Aug 2020 02:02:42 -0400 Original-Received: from [176.228.60.248] (port=3637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6SnZ-0000dB-Qg; Fri, 14 Aug 2020 02:02:42 -0400 In-Reply-To: <7248DF65-C427-4D10-AD48-3240B3EF66A7@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 13 Aug 2020 21:50:33 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253754 Archived-At: > From: Mattias Engdegård > Date: Thu, 13 Aug 2020 21:50:33 +0200 > Cc: emacs-devel@gnu.org > > 12 aug. 2020 kl. 21.21 skrev Eli Zaretskii : > > > I just counted its callers, that's all. A change in a function that > > has many callers could have unintended consequences beyond the > > function itself. > > I'm very happy that you are taking an interest in Calc again, and especially that you took the trouble of digging into the ramifications of this little correction! I'm most curious to hear what you found out. You see, when the change to calcFunc-gcd was made, naturally I did look at its callers carefully to assess the impact. Now since you brought it up I've done so again, and found nothing new: all users of that function are either indifferent to the change, or actively benefit from it. > > It seems clear that the code is less buggy now than before the change and should therefore be preferred for the sake of correctness. However, I could be wrong, and would very much benefit from your findings so that my mistakes can be fixed on master! We are assessing this from two very different points of view: you are thinking about fixing the bug, and I'm thinking about the dangers of some unintended consequences of the fix destabilizing Emacs 27.2's version of Calc. By their very nature, unintended consequences are unknown to you and to me, so asking for any specific details is not useful. (And could you please drop the thinly-veiled sarcasm, here and elsewhere? It makes it harder for me to discuss serious issues with you, and I don't think I deserve the implied attitude, while doing my job of keeping the release branch stable.)