From: Eli Zaretskii <eliz@gnu.org>
To: Rich Felker <dalias@libc.org>
Cc: dmantipov@yandex.ru, emacs-devel@gnu.org
Subject: Re: Dumper problems and a possible solutions
Date: Wed, 25 Jun 2014 23:15:02 +0300 [thread overview]
Message-ID: <83tx78pwzd.fsf@gnu.org> (raw)
In-Reply-To: <20140625195730.GA179@brightrain.aerifal.cx>
> Date: Wed, 25 Jun 2014 15:57:30 -0400
> From: Rich Felker <dalias@libc.org>
> Cc: dmantipov@yandex.ru, emacs-devel@gnu.org
>
> > But I still don't understand how you get to 400MB. It's not that we
> > allocate hundreds of those 700K tables for charsets. Do you have an
> > explanation for this?
>
> Not hundreds at a time, but if the malloc operation is just positive
> (fake-)sbrk and the free operation is a nop, hundreds of such charset
> load operations will quickly add up.
Free operation shouldn't be a no-op, not in malloc.
And still, there are only a few (maybe 10) times we allocate these
700K tables, so 400MB sound very strange to me.
> > Sorry, I don't see the difficulty. Just make malloc/realloc/free be
> > pointers that point to gmalloc's implementation before dumping, and to
> > the libc implementation after it. You may need some #define to rename
> > malloc to some other symbol, to avoid name clashes. Am I missing
> > something?
>
> Yeah, what happens if, after dumping, the real emacs at runtime ends
> up calling free() on one of the pre-dump pointers?
You intercept the call and do nothing.
> > > No, it's less reliable. See my other posts in the thread about what
> > > happens if you have other libraries linked and they do nontrivial
> > > things prior to dumping (e.g. from static ctors).
> >
> > But in those other posts I thought we agreed that whatever those ctors
> > do is irrelevant, as the dumped Emacs cannot possibly use what they
> > allocate, and those ctors will be invoked again in the dumped Emacs.
>
> Those ctors are free to inspect global data. For example one might
> contain (this sort of idiom is necessary if you can't control the
> relative order of ctors): if (!init) { do_something(); init=1; }. In
> that case, the dump would save the value of init, and do_something()
> would fail to happen at runtime.
That's the same problem as with your clock_gettime, and it must be
fixed anyway, because any ctor run at dump time is almost certainly
picking up data that is irrelevant to the run time.
> > > As an example (I think I mentioned this earlier), if you static
> > > link, musl libc is remembering the clock_gettime vdso pointer from
> > > the pre-dump state and attempting to use it later (which is not
> > > valid because the kernel maps it at a random address).
> >
> > You need to fix your libc to detect that it is re-exec'ed, and
> > re-initialize this stuff.
>
> I don't see any easy way to do that that's not a big violation of
> encapsulation (startup code has no business knowing about
> clock_gettime internals) and the whole efficiency of static linking
> (startup code does not pull in any vdso stuff; that only gets pulled
> in by using a function that needs a vdso lookup).
One way is to have a counter that gets incremented each re-exec. Then
the initialization code of clock_gettime could examine the counter and
re-initialize when its value changes since last time.
next prev parent reply other threads:[~2014-06-25 20:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 17:19 Dumper problems and a possible solutions Rich Felker
2014-06-24 19:27 ` Stefan Monnier
2014-06-24 19:40 ` Rich Felker
2014-06-24 20:24 ` Stefan Monnier
2014-06-24 21:15 ` Rich Felker
2014-06-24 21:37 ` Stefan Monnier
2014-06-25 18:03 ` Dmitry Antipov
2014-06-25 18:08 ` Rich Felker
2014-06-25 18:30 ` Dmitry Antipov
2014-06-25 18:36 ` Rich Felker
2014-06-25 18:36 ` Eli Zaretskii
2014-06-25 18:41 ` Eli Zaretskii
2014-06-26 0:16 ` Stephen J. Turnbull
2014-06-25 18:20 ` Eli Zaretskii
2014-06-25 18:32 ` Rich Felker
2014-06-25 18:49 ` Eli Zaretskii
2014-06-25 19:03 ` Rich Felker
2014-06-25 19:18 ` Eli Zaretskii
2014-06-25 19:57 ` Rich Felker
2014-06-25 20:15 ` Eli Zaretskii [this message]
2014-06-25 20:34 ` Rich Felker
2014-06-26 2:44 ` Eli Zaretskii
2014-06-26 4:28 ` Rich Felker
2014-06-26 15:02 ` Eli Zaretskii
2014-06-25 20:11 ` Stefan Monnier
2014-06-25 20:06 ` Stefan Monnier
2014-06-25 20:24 ` Rich Felker
2014-06-25 21:43 ` Stefan Monnier
2014-06-25 22:07 ` Rich Felker
2014-06-25 23:04 ` Paul Eggert
2014-06-25 23:21 ` Rich Felker
2014-06-25 23:05 ` Stefan Monnier
2014-06-25 23:19 ` Rich Felker
2014-06-26 3:02 ` Dmitry Antipov
2014-06-26 4:14 ` Rich Felker
2014-06-26 4:32 ` Dmitry Antipov
2014-06-26 11:49 ` Rich Felker
2014-06-26 15:03 ` Eli Zaretskii
2014-06-26 15:10 ` Rich Felker
2014-06-25 22:33 ` Andreas Schwab
2014-06-25 20:53 ` Samuel Bronson
2014-06-25 21:24 ` Rich Felker
2014-06-25 18:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tx78pwzd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dalias@libc.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).