unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec
Date: Mon, 25 Jun 2018 05:34:03 +0300	[thread overview]
Message-ID: <83tvprsig4.fsf@gnu.org> (raw)
In-Reply-To: <87lgb36dlc.fsf@red-bean.com> (message from Karl Fogel on Sun, 24 Jun 2018 17:09:51 -0500)

> From: Karl Fogel <kfogel@red-bean.com>
> Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>,  emacs-devel@gnu.org
> Date: Sun, 24 Jun 2018 17:09:51 -0500
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> >> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> >> Date: Sun, 24 Jun 2018 09:42:39 -0400
> >> Cc: Karl Fogel <kfogel@red-bean.com>
> >> 
> >> > +If you wish to override a primitive interactive specification, just
> >> > +set the @code{interactive-form} property of the primitive function's
> >> > +symbol (@pxref{Using Interactive}).  There is no need to edit C code
> >> > +and recompile Emacs.
> >> 
> >> You can also use advice-add for the same purpose (it's more
> >> complicated, but it's arguably better behaved).
> >
> >And I wonder whether this text belongs to the "Internals" appendix.  I
> >think its discoverability there will be too low.  Why not put it in
> >"Using Interactive", instead of cross-referencing there?
> 
> When you say "this text", are you referring to the new text I just added on the emacs-26 branch in commit 9a53b6d426 (quoted above), or to Stefan's proposed new text (not yet written) about recommending `advice-add' instead?
> 
> I'm pretty sure you meant the latter, but I wanted to make sure of that before commenting further.

No, I meant the former: your original addition.

"Internals" is where the reader learns how to write Emacs primitives
and how some features work internally.  It is a place where Lisp
programmers seldom if ever look for stuff that's important for writing
Lisp programs.  Your text is for those Lisp programmers, so IMO it
doesn't belong where you put it.



  reply	other threads:[~2018-06-25  2:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180624121111.28772.8847@vcs0.savannah.gnu.org>
     [not found] ` <20180624121113.215CF206CC@vcs0.savannah.gnu.org>
2018-06-24 13:42   ` [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec Stefan Monnier
2018-06-24 13:54     ` `interactive-form` symbol property (was: [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec) Stefan Monnier
2018-06-24 15:27       ` Drew Adams
2018-06-24 15:48         ` `interactive-form` symbol property Stefan Monnier
2018-06-24 17:19           ` Drew Adams
2018-06-24 21:57         ` `interactive-form` symbol property (was: [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec) Radon Rosborough
2018-06-24 15:40       ` `interactive-form` symbol property Basil L. Contovounesios
2018-06-24 15:56         ` Stefan Monnier
2018-06-24 16:20           ` Eli Zaretskii
2018-06-25 12:32             ` Stefan Monnier
2018-06-25 15:19               ` Eli Zaretskii
2018-06-25 20:22                 ` Stefan Monnier
2018-06-24 14:44     ` [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec Eli Zaretskii
2018-06-24 22:09       ` Karl Fogel
2018-06-25  2:34         ` Eli Zaretskii [this message]
2018-06-25  3:47           ` Karl Fogel
2018-06-25 12:43             ` Karl Fogel
2018-06-25 14:41               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tvprsig4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).