From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 9a53b6d: Say how to override a primitive interactive spec Date: Mon, 25 Jun 2018 05:34:03 +0300 Message-ID: <83tvprsig4.fsf@gnu.org> References: <20180624121111.28772.8847@vcs0.savannah.gnu.org> <20180624121113.215CF206CC@vcs0.savannah.gnu.org> <83d0wgtfa3.fsf@gnu.org> <87lgb36dlc.fsf@red-bean.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1529893928 8473 195.159.176.226 (25 Jun 2018 02:32:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2018 02:32:08 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 04:32:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXHIS-00026N-9y for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 04:32:04 +0200 Original-Received: from localhost ([::1]:43868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXHKZ-00041B-Lk for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2018 22:34:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXHKS-00040q-D5 for emacs-devel@gnu.org; Sun, 24 Jun 2018 22:34:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXHKP-0005o8-8x for emacs-devel@gnu.org; Sun, 24 Jun 2018 22:34:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXHKP-0005nu-5g; Sun, 24 Jun 2018 22:34:05 -0400 Original-Received: from [176.228.60.248] (port=4462 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fXHKO-0000Hk-Ai; Sun, 24 Jun 2018 22:34:04 -0400 In-reply-to: <87lgb36dlc.fsf@red-bean.com> (message from Karl Fogel on Sun, 24 Jun 2018 17:09:51 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226694 Archived-At: > From: Karl Fogel > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Sun, 24 Jun 2018 17:09:51 -0500 > > Eli Zaretskii writes: > >> From: Stefan Monnier > >> Date: Sun, 24 Jun 2018 09:42:39 -0400 > >> Cc: Karl Fogel > >> > >> > +If you wish to override a primitive interactive specification, just > >> > +set the @code{interactive-form} property of the primitive function's > >> > +symbol (@pxref{Using Interactive}). There is no need to edit C code > >> > +and recompile Emacs. > >> > >> You can also use advice-add for the same purpose (it's more > >> complicated, but it's arguably better behaved). > > > >And I wonder whether this text belongs to the "Internals" appendix. I > >think its discoverability there will be too low. Why not put it in > >"Using Interactive", instead of cross-referencing there? > > When you say "this text", are you referring to the new text I just added on the emacs-26 branch in commit 9a53b6d426 (quoted above), or to Stefan's proposed new text (not yet written) about recommending `advice-add' instead? > > I'm pretty sure you meant the latter, but I wanted to make sure of that before commenting further. No, I meant the former: your original addition. "Internals" is where the reader learns how to write Emacs primitives and how some features work internally. It is a place where Lisp programmers seldom if ever look for stuff that's important for writing Lisp programs. Your text is for those Lisp programmers, so IMO it doesn't belong where you put it.