From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master b8062be 3/5: Remove some compat code from eudc-bob.el
Date: Fri, 14 Aug 2020 09:05:00 +0300 [thread overview]
Message-ID: <83tux5lq43.fsf@gnu.org> (raw)
In-Reply-To: <jwvwo22fhmu.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 13 Aug 2020 15:54:43 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Thu, 13 Aug 2020 15:54:43 -0400
>
> >> >> > In unibyte buffers the coding-system doesn't matter.
> >> > Again, this factoid isn't relevant to the issue at hand.
> >> Not sure what is the issue at hand at this point
> > The code in eudc-bob.el, of course.
>
> In that particular case, I don't know whether the coding-system will
> make a difference because I don't know if the `data` will contain
> newlines and if so whether their encoding is significant.
If newline conversion is the only consideration, we could bind
inhibit-eol-conversion instead, no need for the coding-system stuff.
My point is that code which makes a buffer unibyte and then sets its
buffer-file-coding-system yells "FIXME!", so it is best not to write
it.
next prev parent reply other threads:[~2020-08-14 6:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200812175454.4839.92908@vcs0.savannah.gnu.org>
[not found] ` <20200812175456.C5D122172E@vcs0.savannah.gnu.org>
2020-08-12 17:56 ` master b8062be 3/5: Remove some compat code from eudc-bob.el Lars Ingebrigtsen
2020-08-12 18:15 ` Stefan Monnier
2020-08-13 8:08 ` Lars Ingebrigtsen
2020-08-13 13:14 ` Eli Zaretskii
2020-08-13 13:58 ` Stefan Monnier
2020-08-13 14:14 ` Eli Zaretskii
2020-08-13 14:23 ` Stefan Monnier
2020-08-13 16:43 ` Eli Zaretskii
2020-08-13 17:43 ` Stefan Monnier
2020-08-13 18:25 ` Eli Zaretskii
2020-08-13 19:02 ` Stefan Monnier
2020-08-13 19:06 ` Eli Zaretskii
2020-08-13 19:54 ` Stefan Monnier
2020-08-14 6:05 ` Eli Zaretskii [this message]
2020-08-14 9:54 ` Lars Ingebrigtsen
2020-08-14 10:35 ` Eli Zaretskii
2020-08-14 11:03 ` Eli Zaretskii
2020-08-15 9:53 ` Lars Ingebrigtsen
2020-08-15 12:56 ` Stefan Monnier
2020-08-15 15:10 ` Eli Zaretskii
2020-08-16 11:17 ` Lars Ingebrigtsen
2020-08-16 14:41 ` Eli Zaretskii
2020-08-17 8:32 ` Lars Ingebrigtsen
2020-08-17 13:15 ` Stefan Monnier
2020-08-18 14:56 ` Lars Ingebrigtsen
2020-08-18 15:08 ` Eli Zaretskii
2020-08-18 17:02 ` Stefan Monnier
2020-08-19 10:20 ` Lars Ingebrigtsen
2020-08-17 14:17 ` Eli Zaretskii
2020-08-13 13:33 ` Stefan Monnier
2020-08-15 21:19 ` Stefan Monnier
2020-08-15 21:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tux5lq43.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).